Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master branch to 10_6_0 #361

Merged
merged 633 commits into from
May 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
633 commits
Select commit Hold shift + click to select a range
10d5399
Fix bestchoice config
jbsauvan Apr 20, 2019
625241d
Apply code-format
jbsauvan Apr 23, 2019
659902c
Implement comments PR #26545
jbsauvan Apr 27, 2019
b950223
Merge pull request #26578 from Dr15Jones/memoryCleanupG4
cmsbuild May 3, 2019
2413cca
Merge pull request #26541 from cms-tau-pog/CMSSW_10_6_X_tau-pog_MVA20…
cmsbuild May 3, 2019
1c8f167
Merge pull request #26572 from plujan/Pileup2017UL
cmsbuild May 3, 2019
40f6198
Merge pull request #26591 from makortel/esConsumesGeometryHGCalCommon…
cmsbuild May 3, 2019
aa58e4c
Review and fixes
ianna May 3, 2019
3f1e190
code-format: changes needed to avoid recursive code formating
smuzaffar May 3, 2019
7326d4b
Code checks fix
ianna May 3, 2019
65f272d
Also add pdgID_ field as target such that ioread rule is actually run
steggema May 3, 2019
7d4a341
Code format fixes
ianna May 3, 2019
d327ad6
First part of code-check comments implemented
forthommel May 3, 2019
7482b13
Apply code formatting rules
steggema May 3, 2019
baf084b
Removed the now unused doNothing flag
forthommel May 3, 2019
5f10f5a
Refactored module constructor
forthommel May 3, 2019
cd01a63
Homogenised filling part, using local track lite collection alias
forthommel May 3, 2019
308bfa4
Code-checks applied
forthommel May 3, 2019
c557ba5
Improves code documentation
forthommel May 3, 2019
150faca
Code format (2)
forthommel May 3, 2019
6033dd3
@cmsbuild's seems to be even more pedantic than the default lxplus e…
forthommel May 3, 2019
0c83db3
switch off fillShowerDigis in recoFromReco step
Fedespring May 2, 2019
974ccf4
Fix code checks
ianna May 3, 2019
c14dfd6
reverted #26501
Fedespring May 3, 2019
22c28dc
Changes from scram build code-format-all
wddgit May 3, 2019
19a183a
Fix dressed lepton constituents, add tau ghosts
mseidel42 May 3, 2019
3560563
clang-tidy
smuzaffar May 3, 2019
61a9b1c
Remove printout
mseidel42 May 3, 2019
0402785
Changes from scram build code-checks
wddgit May 3, 2019
90822e0
Change macro name to make it unique
wddgit May 3, 2019
3d683a1
Clang-tidy
cmsbuild May 3, 2019
46c1db4
Clang-Format
cmsbuild May 3, 2019
fed990a
Add new access code for scintillator cells of HGCal
May 3, 2019
e9909fb
Merge pull request #26586 from slava77/patch-57
cmsbuild May 3, 2019
843235a
Merge pull request #26596 from Dr15Jones/python3FWCoreParameterSet
cmsbuild May 3, 2019
45b5000
Merge pull request #25883 from spandeyehep/PFEnergyCalibration_code_e…
cmsbuild May 3, 2019
36bffb5
Clang-Format
cmsbuild May 3, 2019
a9ceca9
Clang-tidy
cmsbuild May 3, 2019
42078ce
Clang-Format
cmsbuild May 3, 2019
83fcc11
Clang-Format
cmsbuild May 3, 2019
a69b6fd
Clang-tidy
cmsbuild May 3, 2019
c92b27e
Clang-Format
cmsbuild May 3, 2019
9ef0e28
Clang-tidy
cmsbuild May 3, 2019
34bb058
Clang-Format
cmsbuild May 3, 2019
136159f
Clang-tidy
cmsbuild May 4, 2019
6773694
Clang-Format
cmsbuild May 4, 2019
86a6195
Clang-tidy
cmsbuild May 4, 2019
a6c1325
Clang-Format
cmsbuild May 4, 2019
d42c8c8
Clang-Format
cmsbuild May 4, 2019
852f502
Clang-tidy
cmsbuild May 4, 2019
9837f63
Clang-Format
cmsbuild May 4, 2019
acee3a1
Manual changes needed to avoid code-checks
cmsbuild May 4, 2019
00ad176
Clang-tidy
cmsbuild May 4, 2019
ab77615
Clang-Format
cmsbuild May 4, 2019
b990340
Merge pull request #26616 from intrepid42/PLP_DressedLeptonUpdate
cmsbuild May 4, 2019
96e83d2
Use explicit type for lambda in CaloSD
Dr15Jones May 4, 2019
3d71f1c
do provenance check only once per collection retrieval and only when …
slava77devel May 4, 2019
ad4afef
Merge pull request #26621 from cms-sw/code-format-simulation-19d64f
cmsbuild May 4, 2019
2862fa6
Merge pull request #26623 from cms-sw/code-format-simulation-ae618d
cmsbuild May 4, 2019
39db059
Merge pull request #26632 from cms-sw/code-format-simulation-7623f6
cmsbuild May 4, 2019
4d6a1e5
Merge pull request #26624 from cms-sw/code-format-simulation-a72090
cmsbuild May 4, 2019
34e54d7
Replace Phase 2 with Phase 1 modifier
tsusa May 5, 2019
3fff847
Output BadFEDChannel only for Phase 1 detector
tsusa May 5, 2019
7b81013
Merge pull request #26634 from slava77/CMSSW_10_6_X_2019-04-30-2300/d…
cmsbuild May 6, 2019
a306e20
Merge pull request #26633 from Dr15Jones/gcc9SimG4CMSCalo
cmsbuild May 6, 2019
107a7a2
Merge pull request #26626 from cms-sw/code-format-alca-2e32b5
cmsbuild May 6, 2019
db1db8a
Merge pull request #26630 from cms-sw/code-format-alca-131a30
cmsbuild May 6, 2019
4818e56
Merge branch 'master' into RivetSharedResources
mseidel42 May 6, 2019
c54b786
[HeaderCheck] Cleanup ALCA headers to avoid header inconsistency errors
smuzaffar May 6, 2019
5d49be7
[HeaderCheck][CORE] Cleanup headers to avoid header inconsistency errors
smuzaffar May 6, 2019
94ac0e4
[HeaderCheck][Sim] DataFormats/SiPixelDigi and Mixing/Base
mrodozov May 6, 2019
19f74e4
removed unused header
smuzaffar May 6, 2019
76aad12
remove unused header
smuzaffar May 6, 2019
a27505e
[HeaderCheck][Sim] SimGeneral/NoiseGenerators
mrodozov May 6, 2019
8da15f9
Removed necessary header
smuzaffar May 6, 2019
3120396
Set HCAL fraction only for neutral hadrons and HF, consistent with se…
steggema May 6, 2019
d5cb9a9
Apply clang-format
fwyzard May 6, 2019
dcdac90
[HeaderCheck][Gen] Pythia8 & Tauola
mrodozov May 6, 2019
c72da21
Fix in case the PrescaleService is not available
fwyzard May 6, 2019
860f3ee
Update Geometry/TrackerCommonData/plugins/dd4hep/DDTIDAxialCableAlgo.cc
cvuosalo May 6, 2019
9f40f38
Update Geometry/TrackerCommonData/plugins/dd4hep/DDTIDAxialCableAlgo.cc
cvuosalo May 6, 2019
c31ca36
check-header fix: removed obsolete header and fix deps
smuzaffar May 6, 2019
222c594
check-header fix: removed obsolete header
smuzaffar May 6, 2019
6537d44
[HeaderCheck][GenIfc] GeneratorInterface/EvtGenInterface
mrodozov May 6, 2019
901347d
Add modifier for L1 prefiring weight storage
peruzzim May 6, 2019
9497334
Activate storage of L1 prefiring weight in miniAOD
peruzzim May 6, 2019
37c8539
[HeaderCheck][DQM-GEN] Validation/EventGenerator
mrodozov May 6, 2019
fbef1f2
removed obsolete headers
smuzaffar May 6, 2019
7db5190
setting up lumiflag for just METSig
iatakisi May 6, 2019
475a3d4
code checks
iatakisi May 6, 2019
e7f03ab
removed un-used headers
smuzaffar May 6, 2019
72d89e8
[HeaderCheck][Reco] RecoVertex/KinematicFitPrimitives
mrodozov May 6, 2019
3eb1526
deleted obsolete header files
smuzaffar May 6, 2019
1245e76
delete files which are no long used
smuzaffar May 6, 2019
711c363
[HeaderCheck][Reco] CommonTools/RecoAlgos & MagneticField/Interpolation
mrodozov May 6, 2019
2cad9ab
[HeaderCheck][Reco] RecoVertex/MultiVertexFit
mrodozov May 6, 2019
43e4b73
Migrate ESProducers to EventSetup consumes
makortel May 2, 2019
cce4ce0
Migrate EDAnalyzers to EventSetup consumes
makortel May 2, 2019
0d95aaf
Merge pull request #26510 from mmusich/introduceBHforPhase1
cmsbuild May 6, 2019
2af31b8
Merge pull request #26605 from smuzaffar/code-format-avoid-recursive-…
cmsbuild May 6, 2019
d6b1c1e
Merge pull request #26597 from intrepid42/RivetSharedResources
cmsbuild May 6, 2019
dfc4d32
Merge pull request #26639 from smuzaffar/header-chk-core
cmsbuild May 6, 2019
8cc7661
Merge pull request #26649 from smuzaffar/geometry
cmsbuild May 6, 2019
e417dae
Add prefiring weights to MINIAOD output
peruzzim May 6, 2019
a489ddf
add nano 2018 _102Xv1 steps
slava77 May 6, 2019
75992b6
make 136.8521 using 102X inputs to use 102Xv1 nano mods
slava77 May 6, 2019
ccfe5ad
derive mods incrementally from 2018
slava77 May 6, 2019
e42ffef
Modernized CTPPSGeometryESModule
Dr15Jones May 7, 2019
8433038
changed condition on line 225 to subdetCondition
jfan20 May 7, 2019
3d54467
Squashed commit of the following:
May 7, 2019
0b2d185
Merge pull request #26643 from smuzaffar/header-chk-db
cmsbuild May 7, 2019
1c57cc9
Merge pull request #26506 from steggema/CMSSW_10_6_X_PackedCandidateM…
cmsbuild May 7, 2019
da2a03f
Merge pull request #26544 from ghugo83/master
cmsbuild May 7, 2019
784180f
Merge pull request #26582 from Dr15Jones/constCorrectL1THGCal
cmsbuild May 7, 2019
6acbe70
Merge pull request #26671 from makortel/esConsumesGeometryHcalCommonData
cmsbuild May 7, 2019
1e9dc05
Merge pull request #26650 from smuzaffar/header-chk-l1
cmsbuild May 7, 2019
f9603dc
Get rid of useless repeated config_.exists() in SiPixelRawToDigi.cc
perrotta May 7, 2019
89cfb7d
fix up integer division
davidlange6 May 7, 2019
0c7fd69
First obvious changes
boudoul Apr 25, 2019
bcc6ef1
2nd round of 2019 migration
boudoul Apr 25, 2019
8ca7329
2021 Migration
boudoul Apr 25, 2019
59590fe
unit test fixes
davidlange6 May 7, 2019
ec90ee3
Finishing with relval step ....
boudoul Apr 25, 2019
608342c
forgot the lack od 2021 in the GT name
boudoul Apr 25, 2019
bfeb537
Preserving 2019 for actual changes during this particular year
boudoul Apr 30, 2019
c1d7538
Preserving 2019 for actual changes during this particular year
boudoul Apr 30, 2019
8898bff
Keeping 2019 for DB tag and updating GeometryConf
boudoul May 3, 2019
e9bc773
Keeping 2019 in 2019XML_cfi
boudoul May 3, 2019
8fa89ee
remove also .cc file
mrodozov May 7, 2019
a87a020
addressing Ianna's comments
boudoul May 7, 2019
b592706
Used the random number service of the framework
tonydp03 May 7, 2019
4c33538
fix integer divisions
davidlange6 May 7, 2019
afe87d4
Implement requested changes
veszpv May 7, 2019
7121ba9
Fix MessageService unit tests, update reference files
wddgit May 7, 2019
aec25f3
Merge pull request #26534 from guitargeek/PFProducer_cleanup_2
cmsbuild May 7, 2019
707d82d
Merge pull request #26556 from makortel/fixGccRecoMETMETProducers
cmsbuild May 7, 2019
14d40ab
Merge pull request #26590 from kpedro88/BetterEraImports5
cmsbuild May 7, 2019
f686c84
Merge pull request #26619 from cms-sw/code-format-dqm-52ae65
cmsbuild May 7, 2019
8ce7145
Merge pull request #26627 from cms-sw/code-format-dqm-3fca94
cmsbuild May 7, 2019
e0d7bdb
Merge pull request #26615 from Fedespring/from-CMSSW_10_6_0_pre4-rebX
cmsbuild May 7, 2019
687a920
Merge pull request #26628 from cms-sw/code-format-dqm-5d373f
cmsbuild May 7, 2019
e848c05
Merge pull request #26629 from cms-sw/code-format-l1-19c6b5
cmsbuild May 7, 2019
3fa9341
Merge pull request #26631 from cms-sw/code-format-dqm-a1f9c0
cmsbuild May 7, 2019
c458253
Merge pull request #26640 from mrodozov/hdr-cks-sim1
cmsbuild May 7, 2019
bb02d60
Merge pull request #26642 from smuzaffar/header-chk-daq
cmsbuild May 7, 2019
c43e052
Merge pull request #26545 from PFCal-dev/hgc-tpg-integration-190426
cmsbuild May 8, 2019
a55a7db
Merge pull request #26620 from bsunanda/Phase2-hgx195
cmsbuild May 8, 2019
9e1dd01
Merge pull request #26654 from peruzzim/addL1PrefiringWeights
cmsbuild May 8, 2019
5476bd4
Merge pull request #26656 from smuzaffar/header-chk-reco1
cmsbuild May 8, 2019
589ef19
Merge pull request #26659 from smuzaffar/header-chk-reco2
cmsbuild May 8, 2019
1cf135b
Merge pull request #26660 from mrodozov/hdr-chks-reco1
cmsbuild May 8, 2019
044eec5
Merge pull request #26662 from smuzaffar/header-chk-reco3
cmsbuild May 8, 2019
f70c7bf
Merge pull request #26664 from makortel/esConsumesGeometryHGCalGeometry
cmsbuild May 8, 2019
787afac
Merge pull request #26673 from Dr15Jones/consumesCTPPSGeometryESModule
cmsbuild May 8, 2019
42858b2
Merge pull request #26680 from davidlange6/190507_unit
cmsbuild May 8, 2019
2ae097b
Merge pull request #26681 from perrotta/getRidOfConfigExist
cmsbuild May 8, 2019
e07995b
Merge pull request #26638 from smuzaffar/header-chk-alca
cmsbuild May 8, 2019
fcb19aa
Merge pull request #26644 from mrodozov/hdr-cks-sim2
cmsbuild May 8, 2019
17abd9f
Merge pull request #26667 from mrodozov/hdr-chks-reco3
cmsbuild May 8, 2019
353c42d
Merge pull request #26646 from smuzaffar/header-chk-dqm
cmsbuild May 8, 2019
9a7ad8c
Merge pull request #26647 from mrodozov/hdr-chks-gen1
cmsbuild May 8, 2019
04301ba
Merge pull request #26648 from fwyzard/fix_PSMonitor_if_PrescaleServi…
cmsbuild May 8, 2019
0b8bf44
Merge pull request #26653 from mrodozov/hdr-chks-dqm-gen1
cmsbuild May 8, 2019
f092629
Merge pull request #26655 from iatakisi/patch-1
cmsbuild May 8, 2019
b61bbc5
Clang-Format
cmsbuild May 8, 2019
22aeb75
Clang-Format
cmsbuild May 8, 2019
374248c
Clang-Format
cmsbuild May 8, 2019
7409a58
Clang-Format
cmsbuild May 8, 2019
7614b05
Clang-Format
cmsbuild May 8, 2019
60c8d88
Clang-Format
cmsbuild May 8, 2019
26c4bb5
[HeaderCheck][Sim] Remove unused header in Mixing/Base
mrodozov May 8, 2019
b479770
added match quality and pileup identification information
drkovalskyi May 8, 2019
d5c061c
Phase2 Cluster1D implementation
ianna May 8, 2019
f92240c
Merged master-cmsswmaster from repository cms-nanoAOD with cms-merge-…
peruzzim May 8, 2019
48120ed
Use EventSetup consumes in TrackerDigiGeometryESModule
Dr15Jones May 8, 2019
1818d6e
Merge pull request #26636 from CMSTrackerDPG/from_CMSSW_10_6_0_pre4_s…
cmsbuild May 8, 2019
736d1c9
Merge pull request #26652 from mrodozov/hdr-chks-genifc2
cmsbuild May 8, 2019
0a028bd
Merge pull request #26604 from ianna/dd4hep-dd-tid-axial-cable-algo
cmsbuild May 8, 2019
ded81f7
Merge pull request #26526 from jhucmsresearch2019/OverlapValidation-106X
cmsbuild May 8, 2019
5280726
Merge pull request #26531 from tonydp03/ParticleGun_randomWindowsAndP…
cmsbuild May 8, 2019
3d1dcf6
Merge pull request #26692 from cms-sw/code-format-simulation-74376f
cmsbuild May 8, 2019
7a8d8c0
Merge pull request #26693 from cms-sw/code-format-simulation-e8ddcc
cmsbuild May 8, 2019
9a33fb1
Merge pull request #26696 from cms-sw/code-format-simulation-23f813
cmsbuild May 8, 2019
26acd4f
Merge pull request #26698 from mrodozov/hdr-ck-sim
cmsbuild May 8, 2019
7d4a3c1
Merge pull request #26699 from ianna/fw-phase2-cluster1d
cmsbuild May 8, 2019
85c9d37
Merge pull request #26701 from Dr15Jones/consumesTrackerDigiGeometryE…
cmsbuild May 8, 2019
6d472b8
Merge pull request #26665 from mrodozov/hdr-chks-reco2
cmsbuild May 8, 2019
d8368f7
DataFormats/SiPixelDetId: fix for undefined unordered_map when compil…
gartung May 9, 2019
737ce18
Clang-Format
cmsbuild May 9, 2019
8b014b7
Clang-Format
cmsbuild May 9, 2019
28c42d6
Clang-Format
cmsbuild May 9, 2019
f27611d
Clang-Format
cmsbuild May 9, 2019
57cea53
Clang-Format
cmsbuild May 9, 2019
7f0c057
Clang-Format
cmsbuild May 9, 2019
5c0443f
Clang-tidy
cmsbuild May 9, 2019
6fda101
Clang-Format
cmsbuild May 9, 2019
90d84a5
Clang-Format
cmsbuild May 9, 2019
99dbf5b
Clang-Format
cmsbuild May 9, 2019
1b332fd
Update SiPixelActionExecutor.h
smuzaffar May 9, 2019
75bd1b1
Move tabs to spaces to avoid complaints from the python3 compiler
fabiocos May 9, 2019
bdd053f
Merge pull request #26720 from fabiocos/fc-fixPy3
cmsbuild May 9, 2019
1289feb
Fix in preselection of low pt lepton mva
May 9, 2019
baeb988
Fix: dump HGCal rechit center
Mourtz May 9, 2019
9fc3f03
Changes from scram build code-format-all (clang-format)
wddgit May 9, 2019
ea77de4
Changes from scram b code-checks (clang-tidy)
wddgit May 9, 2019
7b0bae8
adapt ranges in a compatible way with the definition of getNbins
fabiocos May 2, 2019
ffd9bce
Address the multi-dimensional histograms case (comment by A. Perrotta)
fabiocos May 3, 2019
15e4114
Correctly set the upper value for loops in multidimensional histogram…
fabiocos May 9, 2019
f994166
Utilities/General: Replace invalid XML characters in test/BuildFile.xml
gartung May 9, 2019
8bc43f0
Update BuildFile.xml
gartung May 9, 2019
071dfd8
Replace ROOT ClassDef macro with ClassDefOverride
wddgit May 9, 2019
b675f97
removing unused header
alberto-sanchez May 9, 2019
6e67838
Merge pull request #26302 from cms-met/FixMETUncertainties2019_port_t…
cmsbuild May 9, 2019
8497776
Merge pull request #26607 from forthommel/patch-3
cmsbuild May 9, 2019
44e2a56
Merge pull request #26672 from slava77/patch-58
cmsbuild May 9, 2019
ebb659b
Merge pull request #26535 from boudoul/2021migration
cmsbuild May 9, 2019
ae6496a
Merge pull request #26682 from davidlange6/190507_div2
cmsbuild May 9, 2019
b91bd57
Merge pull request #26651 from battibass/dtDigiTask_SliceTest_v106X
cmsbuild May 9, 2019
b215011
Merge pull request #26690 from cms-sw/code-format-dqm-8124cf
cmsbuild May 9, 2019
7ac4eaa
Merge pull request #26694 from cms-sw/code-format-dqm-d17987
cmsbuild May 9, 2019
949a7b9
Merge pull request #26713 from cms-sw/code-format-dqm-76b8bb
cmsbuild May 9, 2019
2f76c3d
Merge pull request #26714 from cms-sw/code-format-dqm-9d6191
cmsbuild May 9, 2019
bab3e4b
Merge pull request #26704 from drkovalskyi/10_6_X_extra_sim_info_for_…
cmsbuild May 9, 2019
b22c5fb
Merge pull request #26723 from sscruz/POG_LowPtLeptonMVA_fix
cmsbuild May 9, 2019
ce6799f
Merge pull request #26617 from wddgit/clangFormatRestOfFWCore
cmsbuild May 9, 2019
e181325
Merge pull request #26593 from fabiocos/fc-fixRelMon
cmsbuild May 9, 2019
e03b33d
Rename UP19 to UP21 in matrix workflows and introduce phase1_2021_cos…
mmusich May 8, 2019
dd39f09
Merge pull request #26717 from cms-sw/code-format-alca-5db461
cmsbuild May 10, 2019
37ea175
Merge pull request #26716 from cms-sw/code-format-alca-26afc9
cmsbuild May 10, 2019
2348fb9
Merge pull request #26711 from cms-sw/code-format-alca-91bbb2
cmsbuild May 10, 2019
04f3139
Merge pull request #26695 from cms-sw/code-format-alca-f3d3a2
cmsbuild May 10, 2019
fcbd087
Merge pull request #26732 from alberto-sanchez/remove-unneed-header
cmsbuild May 10, 2019
11d0e88
Merge pull request #26729 from wddgit/clangFormatIOPool
cmsbuild May 10, 2019
3f6f0b8
Merge pull request #26725 from Mourtz/center-calc-fix
cmsbuild May 10, 2019
d117b7e
Merge pull request #26522 from depasse/PFRecHits
cmsbuild May 10, 2019
18d740c
Bugfix in interpolated optics updates.
jan-kaspar May 10, 2019
848a8a2
Merge pull request #26688 from mmusich/renameUP19toUP21
cmsbuild May 10, 2019
2ef6419
Merge pull request #26708 from gartung/DataFormats-SiPixelDetId-clang…
cmsbuild May 10, 2019
c079135
Merge pull request #26710 from cms-sw/code-format-simulation-676d3e
cmsbuild May 10, 2019
3252ab4
Merge pull request #26718 from cms-sw/code-format-simulation-081fe0
cmsbuild May 10, 2019
66cf5e6
Merge pull request #26719 from cms-sw/code-format-simulation-49f4b1
cmsbuild May 10, 2019
914f21e
Merge pull request #26730 from gartung/Utilities-General-test-validxml
cmsbuild May 10, 2019
6c72504
Merge branch 'master' into code-format-simulation-bc9e9d
fabiocos May 10, 2019
c59f484
Update ES_PixelFEDChannelCollectionMap.cc
fabiocos May 10, 2019
b3a035f
Merge pull request #26715 from cms-sw/code-format-simulation-bc9e9d
cmsbuild May 10, 2019
fb30669
Merge pull request #26739 from CTPPS/proton_reco_fix2
cmsbuild May 11, 2019
9cc73ff
Merge pull request #26072 from dseith/master
cmsbuild May 11, 2019
6f20e2e
Merge pull request #26537 from mrodozov/dqm-bump-tobject-versions-pr-…
cmsbuild May 11, 2019
5d7c99f
Merge pull request #26703 from cms-nanoAOD/nanoPR_106X_190508
cmsbuild May 12, 2019
b45186e
Merge pull request #26679 from veszpv/RestoreFEDErrorTreatmentForPhas…
cmsbuild May 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
182 changes: 103 additions & 79 deletions Alignment/APEEstimation/interface/EventVariables.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,49 +3,73 @@

#include <vector>

struct TrackStruct{

TrackStruct(){}

enum HitState{notInTracker, notAssignedToSectors, invalid, negativeError, ok};

struct HitParameterStruct{

HitParameterStruct(): hitState(ok),
isPixelHit(false),
goodXMeasurement(false),
goodYMeasurement(false),
widthX(0),
baryStripX(-999.F),
widthY(0),
baryStripY(-999.F),
chargePixel(-999.F),
clusterProbabilityXY(-999.F), clusterProbabilityQ(-999.F),
clusterProbabilityXYQ(-999.F), logClusterProbability(-999.F),
isOnEdge(false), hasBadPixels(false), spansTwoRoc(false),
qBin(-1),
isModuleUsable(true),
chargeStrip(0),
maxStrip(0), maxStripInv(0), maxCharge(0), maxIndex(0),
chargeOnEdges(-999.F), chargeAsymmetry(-999.F),
chargeLRplus(-999.F), chargeLRminus(-999.F),
sOverN(-999.F),
projWidth(-999.F),
resX(-999.F), norResX(-999.F), xHit(-999.F), xTrk(-999.F),
errXHit(-999.F), errXTrk(-999.F), errX(-999.F), errX2(-999.F),
errXHitWoApe(-999.F), errXWoApe(-999.F),
probX(-999.F),
resY(-999.F), norResY(-999.F), yHit(-999.F), yTrk(-999.F),
errYHit(-999.F), errYTrk(-999.F), errY(-999.F), errY2(-999.F),
errYHitWoApe(-999.F), errYWoApe(-999.F),
probY(-999.F),
phiSens(-999.F), phiSensX(-999.F), phiSensY(-999.F){}

struct TrackStruct {
TrackStruct() {}

enum HitState { notInTracker, notAssignedToSectors, invalid, negativeError, ok };

struct HitParameterStruct {
HitParameterStruct()
: hitState(ok),
isPixelHit(false),
goodXMeasurement(false),
goodYMeasurement(false),
widthX(0),
baryStripX(-999.F),
widthY(0),
baryStripY(-999.F),
chargePixel(-999.F),
clusterProbabilityXY(-999.F),
clusterProbabilityQ(-999.F),
clusterProbabilityXYQ(-999.F),
logClusterProbability(-999.F),
isOnEdge(false),
hasBadPixels(false),
spansTwoRoc(false),
qBin(-1),
isModuleUsable(true),
chargeStrip(0),
maxStrip(0),
maxStripInv(0),
maxCharge(0),
maxIndex(0),
chargeOnEdges(-999.F),
chargeAsymmetry(-999.F),
chargeLRplus(-999.F),
chargeLRminus(-999.F),
sOverN(-999.F),
projWidth(-999.F),
resX(-999.F),
norResX(-999.F),
xHit(-999.F),
xTrk(-999.F),
errXHit(-999.F),
errXTrk(-999.F),
errX(-999.F),
errX2(-999.F),
errXHitWoApe(-999.F),
errXWoApe(-999.F),
probX(-999.F),
resY(-999.F),
norResY(-999.F),
yHit(-999.F),
yTrk(-999.F),
errYHit(-999.F),
errYTrk(-999.F),
errY(-999.F),
errY2(-999.F),
errYHitWoApe(-999.F),
errYWoApe(-999.F),
probY(-999.F),
phiSens(-999.F),
phiSensX(-999.F),
phiSensY(-999.F) {}

HitState hitState;
bool isPixelHit;
bool goodXMeasurement, goodYMeasurement;
std::vector<unsigned int> v_sector;

// Cluster parameters
// pixel+strip
unsigned int widthX;
Expand All @@ -54,58 +78,58 @@ struct TrackStruct{
unsigned int widthY;
float baryStripY;
float chargePixel;
float clusterProbabilityXY, clusterProbabilityQ,
clusterProbabilityXYQ, logClusterProbability;
float clusterProbabilityXY, clusterProbabilityQ, clusterProbabilityXYQ, logClusterProbability;
bool isOnEdge, hasBadPixels, spansTwoRoc;
int qBin;
// strip only
bool isModuleUsable;
unsigned int chargeStrip;
unsigned int maxStrip, maxStripInv, maxCharge, maxIndex;
float chargeOnEdges, chargeAsymmetry,
chargeLRplus, chargeLRminus;
float chargeOnEdges, chargeAsymmetry, chargeLRplus, chargeLRminus;
float sOverN;
float projWidth;

// trackFit results
float resX, norResX, xHit, xTrk,
errXHit, errXTrk, errX, errX2,
errXHitWoApe, errXWoApe,
probX;
float resY, norResY, yHit, yTrk,
errYHit, errYTrk, errY, errY2,
errYHitWoApe, errYWoApe,
probY;
float resX, norResX, xHit, xTrk, errXHit, errXTrk, errX, errX2, errXHitWoApe, errXWoApe, probX;
float resY, norResY, yHit, yTrk, errYHit, errYTrk, errY, errY2, errYHitWoApe, errYWoApe, probY;
float phiSens, phiSensX, phiSensY;
};

struct TrackParameterStruct{

TrackParameterStruct(): hitsSize(-999), hitsValid(-999), hitsInvalid(-999),
hits2D(-999), layersMissed(-999),
hitsPixel(-999), hitsStrip(-999),
charge(-999),
chi2(-999.F), ndof(-999.F), norChi2(-999.F), prob(-999.F),
eta(-999.F), etaErr(-999.F), theta(-999.F),
phi(-999.F), phiErr(-999.F),
d0(-999.F), d0Beamspot(-999.F), d0BeamspotErr(-999.F),
dz(-999.F), dzErr(-999.F), dzBeamspot(-999.F),
p(-999.F), pt(-999.F), ptErr(-999.F),
meanPhiSensToNorm(-999.F){}

int hitsSize, hitsValid, hitsInvalid,
hits2D, layersMissed,
hitsPixel, hitsStrip,
charge;
float chi2, ndof, norChi2, prob,
eta, etaErr, theta,
phi, phiErr,
d0, d0Beamspot, d0BeamspotErr,
dz, dzErr, dzBeamspot,
p, pt, ptErr,
meanPhiSensToNorm;

struct TrackParameterStruct {
TrackParameterStruct()
: hitsSize(-999),
hitsValid(-999),
hitsInvalid(-999),
hits2D(-999),
layersMissed(-999),
hitsPixel(-999),
hitsStrip(-999),
charge(-999),
chi2(-999.F),
ndof(-999.F),
norChi2(-999.F),
prob(-999.F),
eta(-999.F),
etaErr(-999.F),
theta(-999.F),
phi(-999.F),
phiErr(-999.F),
d0(-999.F),
d0Beamspot(-999.F),
d0BeamspotErr(-999.F),
dz(-999.F),
dzErr(-999.F),
dzBeamspot(-999.F),
p(-999.F),
pt(-999.F),
ptErr(-999.F),
meanPhiSensToNorm(-999.F) {}

int hitsSize, hitsValid, hitsInvalid, hits2D, layersMissed, hitsPixel, hitsStrip, charge;
float chi2, ndof, norChi2, prob, eta, etaErr, theta, phi, phiErr, d0, d0Beamspot, d0BeamspotErr, dz, dzErr,
dzBeamspot, p, pt, ptErr, meanPhiSensToNorm;
};

TrackParameterStruct trkParams;
std::vector<HitParameterStruct> v_hitParams;
};
Expand Down
19 changes: 6 additions & 13 deletions Alignment/APEEstimation/interface/ReducedTrackerTreeVariables.h
Original file line number Diff line number Diff line change
@@ -1,28 +1,21 @@
#ifndef ReducedTrackerTreeVariables_h
#define ReducedTrackerTreeVariables_h


// For ROOT types with '_t':
#include <Rtypes.h>



// container to hold those static module parameters needed for correct xPrime-Residual calculation (and others), determined with ideal geometry
struct ReducedTrackerTreeVariables{

ReducedTrackerTreeVariables(){this->clear();}

void clear(){
struct ReducedTrackerTreeVariables {
ReducedTrackerTreeVariables() { this->clear(); }

void clear() {
subdetId = 0;
nStrips = 0;
uDirection = vDirection = wDirection = 0;
}

UInt_t subdetId,
nStrips;

UInt_t subdetId, nStrips;
Int_t uDirection, vDirection, wDirection;
};



#endif
106 changes: 60 additions & 46 deletions Alignment/APEEstimation/interface/TrackerDetectorStruct.h
Original file line number Diff line number Diff line change
@@ -1,57 +1,71 @@
#ifndef Alignment_APEEstimation_TrackerDetectorStruct_h
#define Alignment_APEEstimation_TrackerDetectorStruct_h


#include "TH1.h"
#include "TH2.h"
#include "TProfile.h"

struct TrackerDetectorStruct{

TrackerDetectorStruct(): TrkSize(nullptr), TrkSizeGood(nullptr),
HitsSize(nullptr), HitsValid(nullptr), HitsInvalid(nullptr), Hits2D(nullptr),
HitsGood(nullptr), LayersMissed(nullptr),
HitsPixel(nullptr), HitsStrip(nullptr),
Charge(nullptr),
Chi2(nullptr), Ndof(nullptr), NorChi2(nullptr), Prob(nullptr),
Eta(nullptr), EtaErr(nullptr), EtaSig(nullptr), Theta(nullptr),
Phi(nullptr), PhiErr(nullptr), PhiSig(nullptr),
D0Beamspot(nullptr), D0BeamspotErr(nullptr), D0BeamspotSig(nullptr),
Dz(nullptr), DzErr(nullptr), DzSig(nullptr),
P(nullptr), Pt(nullptr), PtErr(nullptr), PtSig(nullptr),
MeanAngle(nullptr),
HitsGoodVsHitsValid(nullptr), MeanAngleVsHits(nullptr),
HitsPixelVsEta(nullptr), HitsPixelVsTheta(nullptr),
HitsStripVsEta(nullptr), HitsStripVsTheta(nullptr),
PtVsEta(nullptr), PtVsTheta(nullptr),
PHitsGoodVsHitsValid(nullptr), PMeanAngleVsHits(nullptr),
PHitsPixelVsEta(nullptr), PHitsPixelVsTheta(nullptr),
PHitsStripVsEta(nullptr), PHitsStripVsTheta(nullptr),
PPtVsEta(nullptr), PPtVsTheta(nullptr){}

TH1 *TrkSize, *TrkSizeGood,
*HitsSize, *HitsValid, *HitsInvalid, *Hits2D,
*HitsGood, *LayersMissed,
*HitsPixel, *HitsStrip,
*Charge,
*Chi2, *Ndof, *NorChi2, *Prob,
*Eta, *EtaErr, *EtaSig, *Theta,
*Phi,*PhiErr, *PhiSig,
*D0Beamspot, *D0BeamspotErr, *D0BeamspotSig,
*Dz, *DzErr, *DzSig,
*P, *Pt, *PtErr, *PtSig,
*MeanAngle;

TH2 *HitsGoodVsHitsValid, *MeanAngleVsHits,
*HitsPixelVsEta, *HitsPixelVsTheta,
*HitsStripVsEta, *HitsStripVsTheta,
struct TrackerDetectorStruct {
TrackerDetectorStruct()
: TrkSize(nullptr),
TrkSizeGood(nullptr),
HitsSize(nullptr),
HitsValid(nullptr),
HitsInvalid(nullptr),
Hits2D(nullptr),
HitsGood(nullptr),
LayersMissed(nullptr),
HitsPixel(nullptr),
HitsStrip(nullptr),
Charge(nullptr),
Chi2(nullptr),
Ndof(nullptr),
NorChi2(nullptr),
Prob(nullptr),
Eta(nullptr),
EtaErr(nullptr),
EtaSig(nullptr),
Theta(nullptr),
Phi(nullptr),
PhiErr(nullptr),
PhiSig(nullptr),
D0Beamspot(nullptr),
D0BeamspotErr(nullptr),
D0BeamspotSig(nullptr),
Dz(nullptr),
DzErr(nullptr),
DzSig(nullptr),
P(nullptr),
Pt(nullptr),
PtErr(nullptr),
PtSig(nullptr),
MeanAngle(nullptr),
HitsGoodVsHitsValid(nullptr),
MeanAngleVsHits(nullptr),
HitsPixelVsEta(nullptr),
HitsPixelVsTheta(nullptr),
HitsStripVsEta(nullptr),
HitsStripVsTheta(nullptr),
PtVsEta(nullptr),
PtVsTheta(nullptr),
PHitsGoodVsHitsValid(nullptr),
PMeanAngleVsHits(nullptr),
PHitsPixelVsEta(nullptr),
PHitsPixelVsTheta(nullptr),
PHitsStripVsEta(nullptr),
PHitsStripVsTheta(nullptr),
PPtVsEta(nullptr),
PPtVsTheta(nullptr) {}

TH1 *TrkSize, *TrkSizeGood, *HitsSize, *HitsValid, *HitsInvalid, *Hits2D, *HitsGood, *LayersMissed, *HitsPixel,
*HitsStrip, *Charge, *Chi2, *Ndof, *NorChi2, *Prob, *Eta, *EtaErr, *EtaSig, *Theta, *Phi, *PhiErr, *PhiSig,
*D0Beamspot, *D0BeamspotErr, *D0BeamspotSig, *Dz, *DzErr, *DzSig, *P, *Pt, *PtErr, *PtSig, *MeanAngle;

TH2 *HitsGoodVsHitsValid, *MeanAngleVsHits, *HitsPixelVsEta, *HitsPixelVsTheta, *HitsStripVsEta, *HitsStripVsTheta,
*PtVsEta, *PtVsTheta;

TProfile *PHitsGoodVsHitsValid, *PMeanAngleVsHits,
*PHitsPixelVsEta, *PHitsPixelVsTheta,
*PHitsStripVsEta, *PHitsStripVsTheta,
*PPtVsEta, *PPtVsTheta;


TProfile *PHitsGoodVsHitsValid, *PMeanAngleVsHits, *PHitsPixelVsEta, *PHitsPixelVsTheta, *PHitsStripVsEta,
*PHitsStripVsTheta, *PPtVsEta, *PPtVsTheta;
};

#endif
Loading