Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the gpu modifier to read the pixel clusters from the unpacker #31

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Use the gpu modifier to read the pixel clusters from the unpacker #31

merged 1 commit into from
Mar 1, 2018

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Mar 1, 2018

When running the GPU algorithms, the pixel unpacker is reponsible for providing both the digis and the cluster. These changes make use of the unpacker label to access the clusters, conditionally on the presence of the gpu process modifier.

@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker
86838e4 
When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
@cmsbot
Copy link

cmsbot commented Mar 1, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_1_X_Patatrack.

It involves the following packages:

Configuration/StandardSequences
DQM/TrackingMonitorSource
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
Validation/RecoTrack

@cmsbot, @fwyzard can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@fwyzard
Copy link
Author

fwyzard commented Mar 1, 2018

This implements in the gpu modifier the changes necessary to run with #18 .

@fwyzard fwyzard mentioned this pull request Mar 1, 2018
Merged
@fwyzard fwyzard merged commit f44441c into cms-patatrack:CMSSW_10_1_X_Patatrack Mar 1, 2018
@fwyzard fwyzard deleted the Use_gpu_modifier_for_pixel_clusters branch March 1, 2018 19:57
makortel
makortel reviewed Mar 2, 2018
View reviewed changes
RecoLocalTracker/SiPixelClusterizer/python/SiPixelClusterizerPreSplitting_cfi.py

# *only for the cms-patatrack repository*
# ensure reproducibility for CPU <--> GPU comparisons
siPixelClustersPreSplitting.payloadType = 'HLT'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect this to get automatically propagated from SiPixelClusterizer_cfi.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed.

@makortel
Copy link

makortel commented Mar 2, 2018

Do I understand correctly that after #18 siPixelClustersPreSplitting is not needed? If yes, we could remove siPixelClustersPreSplitting from

cmssw/RecoLocalTracker/Configuration/python/RecoLocalTracker_cff.py

Line 16 in f44441c

pixeltrackerlocalreco = cms.Sequence(siPixelClustersPreSplitting*siPixelRecHitsPreSplitting)

with gpu modifier. (on the other hand, with unscheduled execution framework should know that siPixelClustersPreSplitting is not needed)

@fwyzard fwyzard restored the Use_gpu_modifier_for_pixel_clusters branch March 2, 2018 12:35
@fwyzard
Copy link
Author

fwyzard commented Mar 2, 2018

Indeed, the job works just as well adding

del process.siPixelClustersPreSplitting

to the configuration.

However, I'd rather avoid the extra complexity for the time being.

fwyzard added a commit that referenced this pull request Mar 2, 2018
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
bf8a301 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
@fwyzard fwyzard deleted the Use_gpu_modifier_for_pixel_clusters branch March 2, 2018 12:53
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
53c7113 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
12dcc1e 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
This was referenced Oct 8, 2020
Merged
Merged
fwyzard added a commit that referenced this pull request Oct 19, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
46622a7 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
b7e9902 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
e476597 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
b4294f9 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
cbdf51e 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
9f6d00b 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
6edc487 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
2dd0f2f 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
b453611 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
391a962 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
203318d 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
627d48b 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
a066702 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
@cmsbuild @fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
d9992f7 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
@fwyzard fwyzard mentioned this pull request Dec 26, 2020
Merged
fwyzard added a commit that referenced this pull request Dec 26, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
97175b8 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
b518a25 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
b7df6e6 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
fwyzard added a commit that referenced this pull request Jan 15, 2021
@fwyzard
Use the gpu modifier to read the pixel clusters from the unpacker (#31
ec0cc29 
)

When running the GPU algorithms, the pixel unpacker is reponsible
for providing both the digis and the cluster.
These changes make use of the unpacker label to access the clusters,
conditionally on the presence of the `gpu` process modifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbot @makortel