Add missing inline keywords to cudautils::launch

[fwyzard]

This is part of the proposed changes from #428 .

[makortel]

The launch.h is part of cms-sw#28537. @fwyzard, do you agree that I should just cherry-pick the commit there as well (instead of a subsequent PR)?

[fwyzard]

Sure.

[fwyzard]

By the way, clang-format does not seem happy about this file, but I would rather not make the proposed changes:

diff --git a/HeterogeneousCore/CUDAUtilities/interface/launch.h b/HeterogeneousCore/CUDAUtilities/interface/launch.h
index fbf67fbdc59..a72c6a9b6c0 100644
--- a/HeterogeneousCore/CUDAUtilities/interface/launch.h
+++ b/HeterogeneousCore/CUDAUtilities/interface/launch.h
@@ -100,11 +100,11 @@ namespace cudautils {
   template <typename F, typename... Args>
   inline
 #if __cplusplus >= 201703L
-  std::enable_if_t<std::is_invocable_r<void, F, Args&&...>::value>
+      std::enable_if_t<std::is_invocable_r<void, F, Args&&...>::value>
 #else
-  std::enable_if_t<std::is_void<std::result_of_t<F && (Args && ...)> >::value>
+      std::enable_if_t<std::is_void<std::result_of_t<F && (Args && ...)> >::value>
 #endif
-  launch(F* kernel, LaunchParameters config, Args&&... args) {
+      launch(F* kernel, LaunchParameters config, Args&&... args) {
     using function_type = detail::kernel_traits<F>;
     typename function_type::argument_type_tuple args_copy(args...);
 
@@ -126,11 +126,11 @@ namespace cudautils {
   template <typename F, typename... Args>
   inline
 #if __cplusplus >= 201703L
-  std::enable_if_t<std::is_invocable_r<void, F, Args&&...>::value>
+      std::enable_if_t<std::is_invocable_r<void, F, Args&&...>::value>
 #else
-  std::enable_if_t<std::is_void<std::result_of_t<F && (Args && ...)> >::value>
+      std::enable_if_t<std::is_void<std::result_of_t<F && (Args && ...)> >::value>
 #endif
-  launch_cooperative(F* kernel, LaunchParameters config, Args&&... args) {
+      launch_cooperative(F* kernel, LaunchParameters config, Args&&... args) {
     using function_type = detail::kernel_traits<F>;
     typename function_type::argument_type_tuple args_copy(args...);
 

[makortel]

All that because of the added inline?

[fwyzard]

Yep...

Shall I remove it ?
It should be anyway redundant in a template function (for which we do not use explicit instantiation).

[fwyzard]

Removed it :)