Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify offlineBeamSpotCUDA configuration #433

Merged
merged 1 commit into from Jan 31, 2020
Merged

Simplify offlineBeamSpotCUDA configuration #433

merged 1 commit into from Jan 31, 2020

Conversation

makortel
Copy link

PR description:

Just an afterthought to #432 (comment): the offlineBeamSpotCUDA = _beamSpotToCUDA.clone() can be avoided by generating the cfi with the proper name.

PR validation:

Code compiles, profiling workflow runs. Should be purely technical.

@fwyzard
Copy link

fwyzard commented Jan 21, 2020

Should we rename the class to OfflineBeamSpotCUDA ?

@makortel
Copy link
Author

I would not rename the class, because it is agnostic to whether the beamspot originates from "offline" or "online" source. Also offlineBeamSpot is defined similarly to this PR

cmssw/RecoVertex/BeamSpotProducer/python/BeamSpot_cfi.py

Line 5 in 1a6b4f0

offlineBeamSpot = cms.EDProducer("BeamSpotProducer")

I'm also fine with keeping the beamspot configuration as it is now, just wanted to make a suggestion that avoids the clone().

@fwyzard
Copy link

fwyzard commented Jan 22, 2020

Ah, ok. Thanks, the change looks good.

@AdrianoDee
Copy link

AdrianoDee commented Jan 22, 2020 via email

@AdrianoDee
Copy link

AdrianoDee commented Jan 22, 2020 via email

@fwyzard
Copy link

fwyzard commented Jan 22, 2020

Would need validation?

Yes, thanks :-)

@fwyzard
Copy link

fwyzard commented Jan 22, 2020

By the way, can you try to update the validation scripts to use CMSSW_11_0_0_Patatrack as the base release ?

@AdrianoDee
Copy link

AdrianoDee commented Jan 22, 2020 via email

@AdrianoDee
Copy link

Validation summary

Reference release CMSSW_11_0_0_pre13 at 91be707
Development branch cms-patatrack/CMSSW_11_0_X_Patatrack at 1a6b4f0
Testing PRs:

Validation plots

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.501
  • tracking validation plots and summary for workflow 10824.502

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.501
  • tracking validation plots and summary for workflow 10824.502

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.501
  • tracking validation plots and summary for workflow 10824.502

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png
zoom-136.885502.png

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.501
  • development release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • testing release, workflow 10824.5
  • testing release, workflow 10824.501
  • testing release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.501
  • development release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • testing release, workflow 10824.5
  • testing release, workflow 10824.501
  • testing release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.501
  • development release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • testing release, workflow 10824.5
  • testing release, workflow 10824.501
  • testing release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/227538c66480a5118df04319e336be37c71e8fd5/log .

@fwyzard
Copy link

fwyzard commented Jan 22, 2020

Looks good to merge, however I will wait until I have prepared the CMSSW_11_1_X_Patatrack branch, hopefully next week.

@fwyzard fwyzard added this to the CMSSW_11_1_X milestone Jan 22, 2020
@fwyzard fwyzard changed the base branch from CMSSW_11_0_X_Patatrack to CMSSW_11_1_X_Patatrack January 31, 2020 12:54
@fwyzard fwyzard changed the base branch from CMSSW_11_1_X_Patatrack to CMSSW_11_0_X_Patatrack January 31, 2020 12:55
@fwyzard fwyzard merged commit b6adb2d into cms-patatrack:CMSSW_11_0_X_Patatrack Jan 31, 2020
fwyzard pushed a commit that referenced this pull request Jan 31, 2020
@makortel @fwyzard
Simplify the offlineBeamSpotCUDA configuration (#433)
d09335f
fwyzard pushed a commit that referenced this pull request Mar 24, 2020
@peruzzim
Merge pull request #433 from andreypz/nanoAOD-bjet-regression
f214471 
Update b-jet energy regression
@fwyzard fwyzard mentioned this pull request Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CMSSW_11_1_0_Patatrack
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makortel @fwyzard @AdrianoDee