Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating validation sequence for pixel only tracking workflows #548

Merged
merged 7 commits into from
Oct 12, 2020

Conversation

sroychow
Copy link

PR description:

In this PR, the validation modules for pixel digis, clusters and rechits are added to the pixel only tracking validation sequence. The PR also includes a fix for the cut on ndof for the primary vertex monitor.

PR validation:

This has been tested with 11634.0(customized for pixel only tracking), 11634.502.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Copy link

@fwyzard fwyzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up whitespace changes

@fwyzard
Copy link

fwyzard commented Oct 12, 2020

I would propose to merge this PR right after #549, which changes the workflow .501 to run the Patatrack pixel tracks on CPU.
Do you foresee any changes will be needed here once #549 is merged ?

By the way, how can I test that these changes behave as expected?
What plots / etc. should I see ?

@sroychow
Copy link
Author

I would propose to merge this PR right after #549, which changes the workflow .501 to run the Patatrack pixel tracks on CPU.
Do you foresee any changes will be needed here once #549 is merged ?

No we don't foresee any changes after #549 is merged.

By the way, how can I test that these changes behave as expected?
What plots / etc. should I see ?

This PR should not change any existing DQM, Validation plots related to tracks, vertices. Instead it adds new Validation plots for digis, clusters and RecHits(e.g. https://tinyurl.com/y3sfnxy2).

@fwyzard fwyzard merged commit 275b7a3 into cms-patatrack:master Oct 12, 2020
@fwyzard fwyzard added the Pixels Pixels-related developments label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pixels Pixels-related developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants