Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relval comparsion to have long and short names #1897

Merged
merged 5 commits into from Dec 1, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 30, 2022

Change in run-pr-comparisons is a temporary to allow cms-sw/cmssw#40106 to get integrated. Once cms-sw/cmssw#40106 is
integrated and PRs start using IBs with cms-sw/cmssw#40106 then we can remove this change.

Also it enable checking edmEventSize for all root files ( except inDQM.root).

@smuzaffar
Copy link
Contributor Author

please test

lets test it without cms-sw/cmssw#40106

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db46c3/29347/summary.html
COMMIT: f1c9f68
CMSSW: CMSSW_13_0_X_2022-11-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1897/29347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421137
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2022

Pull request #1897 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db46c3/29370/summary.html
COMMIT: 2236f1d
CMSSW: CMSSW_13_0_X_2022-11-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1897/29370/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421136
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2022

Pull request #1897 was updated.

@cms-sw cms-sw deleted a comment from cmsbuild Dec 1, 2022
@smuzaffar
Copy link
Contributor Author

merging it as it looks good with and without cms-sw/cmssw#40106

@smuzaffar smuzaffar merged commit b6c924f into master Dec 1, 2022
@smuzaffar smuzaffar deleted the relval-short-names branch January 11, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants