Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip building cmssw in case of runtime image when testing a new image #200

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

aandvalenzuela
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@aandvalenzuela , looks like the runtime images are really only runtime i.e. one can use it to run preinstalled cmssw. Can you please check what packages are required if we want to use it to install cmssw too?

@smuzaffar
Copy link
Contributor

smuzaffar commented Aug 1, 2023

thinking about it again, if we want runtime images to also support installation then we have to add all the packages which we have in bootstrap seed (which are a lot). I would suggest to add a new test for runtime images which actually use cmssw installation from cvmfs i.e. the test should not do any local cmssw installation but should use releases from cvmfs , create dev area and run short matrix and add on tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

Pull request #200 was updated.

@aandvalenzuela
Copy link
Contributor Author

aandvalenzuela commented Aug 3, 2023

I have tested the script for the runtime image at https://cmssdt.cern.ch/jenkins/job/test-cmssw-images/19/ and for a regular image at https://cmssdt.cern.ch/jenkins/job/test-cmssw-images/20/ (I will delete the job once this PR is merged since this script will run on the regular https://cmssdt.cern.ch/jenkins/job/cms-containers-run-cmssw-test/ job)

@smuzaffar
Copy link
Contributor

tests looks good

bin/test-cmssw.sh Outdated Show resolved Hide resolved
bin/test-cmssw.sh Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

Pull request #200 was updated.

@aandvalenzuela
Copy link
Contributor Author

Thanks @smuzaffar!

@smuzaffar
Copy link
Contributor

looks good. do you plan to change it more or should we merge it?

@aandvalenzuela
Copy link
Contributor Author

We can merge it! :)

@aandvalenzuela aandvalenzuela merged commit c4415d4 into cms-sw:master Aug 3, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants