Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: ignore only those packs which exactly match the change set #119

Merged
merged 1 commit into from May 19, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented May 19, 2021

fixes cms-sw/cmssw#33781
git-cms-checkdeps does not checkout package SubX/PackB if a file SubA/PackA/*/file.h ( which is used by SubX/PackB/*/*) is changed along with file *SubX/PackB*/*/* . There was a check which was ignoring files from package SubX/PackB.

In case of cms-sw/cmssw#33783, L1Trigger/L1TMuon was not checkout because of L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc

@cmsbuild
Copy link

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#33783

@smuzaffar
Copy link
Contributor Author

this has fixed [a] the issue and properly checkout the L1Trigger/L1TMuon package

[a]

+ git cms-checkdeps -A -a
>> Checking DataFormats/CSCDigi CMSSW_12_0_X_2021-05-18-2300
   x DataFormats/CSCDigi/interface/CSCCLCTDigi.h
   x DataFormats/CSCDigi/interface/CSCCorrelatedLCTDigi.h
   x DataFormats/CSCDigi/interface/CSCShowerDigi.h
   x DataFormats/CSCDigi/src/CSCCLCTDigi.cc
   x DataFormats/CSCDigi/src/CSCCorrelatedLCTDigi.cc
   x DataFormats/CSCDigi/src/CSCShowerDigi.cc
   x DataFormats/CSCDigi/src/classes_def.xml
>> Checking DataFormats/L1CSCTrackFinder CMSSW_12_0_X_2021-05-18-2300
   x DataFormats/L1CSCTrackFinder/src/classes_def.xml
>> Checking L1Trigger/CSCTriggerPrimitives CMSSW_12_0_X_2021-05-18-2300
   x L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc
>> Checking L1Trigger/L1TMuonEndCap CMSSW_12_0_X_2021-05-18-2300
   x L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc
Checking out these packages: 52
Calibration/EcalAlCaRecoProducers (header)
Calibration/HcalAlCaRecoProducers (header)
Calibration/HcalIsolatedTrackReco (header)
Calibration/IsolatedParticles (header)
CaloOnlineTools/EcalTools (header)
Configuration/Skimming (header)
DPGAnalysis/Skims (header)
DQM/CSCMonitorModule (header)
DQM/L1TMonitor (header)
DQM/Physics (header)
DQMOffline/JetMET (header)
DQMOffline/Muon (header)
DQMOffline/Trigger (header)
DataFormats/HLTReco (header)
DataFormats/L1TCorrelator (header)
DataFormats/L1TMuon (header)
EventFilter/CSCRawToDigi (header)
EventFilter/CSCTFRawToDigi (header)
EventFilter/L1TRawToDigi (header)
HLTrigger/Egamma (header)
HLTrigger/HLTcore (header)
HLTrigger/HLTfilters (header)
HLTrigger/JetMET (header)
HLTrigger/Muon (header)
HLTrigger/btau (header)
HLTrigger/special (header)
HLTriggerOffline/Egamma (header)
HLTriggerOffline/HeavyFlavor (header)
HLTriggerOffline/Higgs (header)
HLTriggerOffline/JetMET (header)
HLTriggerOffline/Muon (header)
HLTriggerOffline/SUSYBSM (header)
L1Trigger/CSCTrackFinder (header)
L1Trigger/DTTrackFinder (header)
L1Trigger/HardwareValidation (header)
L1Trigger/L1TMuon (header)
L1Trigger/L1TMuonBarrel (header)
L1Trigger/L1TMuonCPPF (header)
L1Trigger/L1TMuonOverlap (header)
L1Trigger/L1TNtuples (header)

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e8fee/15190/summary.html
COMMIT: 03d1520
CMSSW: CMSSW_12_0_X_2021-05-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-git-tools/119/15190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 113498 lines to the logs
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648242
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2648196
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L1Trigger/L1TMuon package not rebuilt in #33727 tests
2 participants