Source hector, sip and pyqt from cms-externals. #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| %patch1 -p1 | ||
| %patch2 -p1 | ||
| %setup -q -n %{n}.%{realversion} | ||
| mkdir -p obj |
There was a problem hiding this comment.
For the record:
mkdir -p obj lib
should be preferred.
|
Thanks. Can you clean up at least the second issue above (well, I guess the first one as well while you are at it)? |
|
@ktf I updated the PR. All should be fine now. |
ghost
pushed a commit
that referenced
this pull request
Mar 11, 2015
Source hector, sip and pyqt from cms-externals.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hector: cms-externals/hector@365361c
Sip: cms-externals/sip@51f6c53
PyQt: cms-externals/pyqt@f909ea8
Cleanup of patch files now included in cms-externals.
+1
Tested compilation up to toolfile of each package.