Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rivet 2.2.1 #1514

Merged
1 commit merged into from Apr 28, 2015
Merged

Conversation

mkirsano
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Apr 28, 2015

+1
Tested compilation and all of its dependencies.
Tested compilation of CMSSW package GeneratorInterface/RivetInterface against it.

@ghost
Copy link

ghost commented Apr 28, 2015

@davidlange6 Merging this now.

ghost pushed a commit that referenced this pull request Apr 28, 2015
@ghost ghost merged commit b0772c4 into cms-sw:IB/CMSSW_7_5_X/stable Apr 28, 2015
@davidlange6
Copy link
Contributor

was about to comment - but I think its still relevant -. could we not remove all of the commented out code in the patch?

@mkirsano
Copy link
Contributor Author

The commented out code does not compile with c++11. It is substituted
by another code.

On 4/28/15 4:51 PM, David Lange wrote:

was about to comment - but I think its still relevant -. could we not
remove all of the commented out code in the patch?


Reply to this email directly or view it on GitHub
#1514 (comment).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants