Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove patch for symlink and force them through makefile opti… #1685

Merged
1 commit merged into from Jul 22, 2015
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2015

…ons instead."

This reverts commit c1077a4.

ghost pushed a commit that referenced this pull request Jul 22, 2015
Revert "Remove patch for symlink and force them through makefile opti…
@ghost ghost merged commit ef0df56 into cms-sw:IB/CMSSW_7_6_X/stable Jul 22, 2015
@ghost ghost deleted the git_revert_nosym76XStable branch July 22, 2015 10:19
@davidlt
Copy link
Contributor

davidlt commented Jul 22, 2015

Could you provide a reason the change?

@smuzaffar
Copy link
Contributor

Looks like symlinks in libexec/git-core directory are causing the problem mentioned here https://hypernews.cern.ch/HyperNews/CMS/get/git/211.html

In CMSSW_7_5_4 runtime env, if we set GIT_EXEC_PATH to one of the git versions where we did not create symlinks (e.g. the one in 7.4.4 release) then above mentioned issue is gone.

while we are trying to understand why git is not happy with symlinks, we decided to revert the change.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants