Move to ROOT pre-6.06 (almost final) #2023
Conversation
On OS X we explicitly disable `libAfterImage`. In that case we need to provide PNG, JPEG, TIFF and GIF libraries as replacement. Without GIF library a built in `libAfterImage` is re-enabled back. There is 5.X version of giflib, but currently Fedora is sticking with 4.X due to ABI/API differences (not investigated further). Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch> Tested-on: slc6_amd64_gcc491 Tested-on: fc19_aarch64_gcc490 Tested-on: osx10A_amd64_clang610
TTreeCache is now on by default. This creates a problem on GEN-SIM jobs
(e.g., 135.4, 5.1). E.g., 135.4 opens 162 ROOT files (not via CMSSW
TFile wrappers) from `FastSimulation/MaterialEffects` data package.
Then `NuclearInteractionSimulator::compute` calls `TTree::GetEntry(long
long, int)`, which calls `TTree::SetCacheSizeAux(bool, long long)`, then
`TTreeCache` is finally created for `TTree`.
This yields almost 400MB extra memory allocations per process lifetime.
The patch should lower peak RSS by ~150MB on 135.4.
To re-enabled behavior like in ROOT5, `ROOT_TTREECACHE_SIZE` and
`ROOT_TTREECACHE_PREFILL` must be set 0 via environment variables or via
`rootrc` file.
For detaill look at ROOT6 commit (cf7cc4b2) and
https://root.cern.ch/root/html604/notes/release-notes.html#ttreecache
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Upda ROOT to pre-final 6.06. The following moves from old JIT to OrcJIT interface, thus allows multiple new architectures to be used, in particular aarch64 and ppc64le (POWER8/9). TFormula was almost rewritten to use Cling. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for branch IB/CMSSW_8_0_X/stable. @cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
@davidlt , @holzman , I guess we are missing cms-sw/root#108 for root 6.06 ...right? |
|
Yes, I guess, this applies fine. I can add this on top. |
Add 'TS3WebFile - add support for session keys' commit which is missing in upstream ROOT. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
Pull request #2023 was updated. |
|
Updated. One commit is already upstreamed, the only missing part in 6.06 seems to be 'TS3WebFile - add support for session keys'. That's the only one I cherry picked. |
|
-1 >> Building edm plugin tmp/slc6_amd64_gcc493/src/CalibMuon/CSCCalibration/test/CSCChipSpeedCorrectionPopConAnalyzer/libCSCChipSpeedCorrectionPopConAnalyzer.so Leaving library rule at src/CalibMuon/CSCCalibration/test @@@@ Running edmWriteConfigs for RecoParticleFlowPFClusterShapeProducerPlugins Leaving library rule at src/CalibMuon/CSCCalibration/test >> Building edm plugin tmp/slc6_amd64_gcc493/src/RecoParticleFlow/Configuration/test/BlockAnalyzer/libBlockAnalyzer.so error: edmWriteConfigs caught an exception while loading a plugin library. The executable will return success (0) so scram will continue, but no cfi files will be written. An exception of category 'PluginLibraryLoadError' occurred. Exception Message: unable to load /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_0_X_2015-12-07-1100/tmp/slc6_amd64_gcc493/src/RecoParticleFlow/PFClusterShapeProducer/plugins/RecoParticleFlowPFClusterShapeProducerPlugins/libRecoParticleFlowPFClusterShapeProducerPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2015-12-06-2300/lib/slc6_amd64_gcc493/libDataFormatsParticleFlowReco.so: undefined symbol: _ZN4ROOT14DefineBehaviorEPvS0_ you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
local tests done by @davidlt looks good. |
Move to ROOT pre-6.06 (almost final)
This is a move to ROOT pre-6.06 (almost final, ROOT commit: 1f31574810df80153353b50167ceb868b520edc5).
Tested on slc6_amd64_gcc493 up to
root-toolfile.