Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance to latest release of RecoBTag/CTagging data. #2106

Merged
merged 1 commit into from Jan 30, 2016
Merged

Advance to latest release of RecoBTag/CTagging data. #2106

merged 1 commit into from Jan 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2016

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for branch IB/CMSSW_8_0_X/stable.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ghost
Copy link
Author

ghost commented Jan 28, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/73/console

@slava77
Copy link
Contributor

slava77 commented Jan 28, 2016

@Degano
I'm looking at https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/73/console
It looks like the full release is recompiled.
This is excessive for data externals.

Is the logic for testing to have a full rebuild for any cmsdist update?
We maybe need to get some improvement to this.

In this case we only needed the new external built and then the matrix&addOn tests rerun.

@cmsbuild
Copy link
Contributor

-1

Tested at: 8bc27c9
I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2106/73/summary.html

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2016

the unit test failures are unrelated, they are present in the IB as well
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_0_X_2016-01-27-2300/unitTestLogs/RecoLocalCalo/HGCalRecProducers

looking at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2106/73/summary.html
even after 11 hours, the comparisons have never completed.

from the change in the code
cms-data/RecoBTag-CTagging@V01-00-00...V01-00-02
it's is clear that only new files are added.
I think at this point it is more important to merge this and have the new training files in the release.
If they are good, we can get the cms-sw/cmssw#13054 in as well.
The last set of tests check only the jenkins test infrastructure, not very successfully.

@ghost
Copy link
Author

ghost commented Jan 29, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/80/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2016

@Degano
which jenkins project is running the comparisons for builds done in cmsdist-test-pr?
The status for this test https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/80/ says there is supposed to be a subproject job in https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/, but I do not see anything relevan there.

Please clarify where to look for the comparison job.
Thank you.

@smoortga
Copy link

Dear @Degano, Dear @slava77,
Since the dealine for the last open 8.0.X. release is only two days away, I was wondering if you could update @mverzett and myself about the status of our PR. It seems like all of the tests discribed above have eventually passed successfully (or is this not the case?), and our cmssw PR (cms-sw/cmssw#13054) is still waiting for this one to be approved.

Thanks a lot!
Cheers, Seth

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2016

@davidlange6
This is just to note that we may need some extra time (or action) to get #13054 through into 80X (once this external update is done).

@davidlange6
Copy link
Contributor

I'll merge it - but yes, any externals update means a full cmssw rebuild.

davidlange6 added a commit that referenced this pull request Jan 30, 2016
Advance to latest release of RecoBTag/CTagging data.
@davidlange6 davidlange6 merged commit 170bcbb into cms-sw:IB/CMSSW_8_0_X/stable Jan 30, 2016
@slava77
Copy link
Contributor

slava77 commented Jan 30, 2016

On 1/30/16 10:58 AM, David Lange wrote:

I'll merge it - but yes, any externals update means a full cmssw rebuild.

Thank you for the merge.
I suppose, the file will show up in the -2300 IB.

The case of data file externals may better be reconsidered.
Although a better way is still to push everything to a GT.
At an extreme, when only this external is changing,
a sub-MB size update in a data file costs a few GB of release space.


Reply to this email directly or view it on GitHub
#2106 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants