New minor version of fasthadd, 2.1, and move llvm sqlite from BuildRequires and Requires for py2-dxr #2147
Conversation
* the new minor version 2.1 is defined so that it is explicitly built on top of the new ROOT 6.0.6, featuring changes in the histogram serialisation; * the code base has been moved to the latest 80X pre-release, but no changes in the source file is done. No changes in performance observed or expected.
|
A new Pull Request was created by @diguida (Salvatore Di Guida) for branch IB/CMSSW_8_0_X/stable. @cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
The issue is in |
|
@davidlt that's correct: I can cherry-pick your commit and re-run the test. Can you point it to me? |
|
That should be it 1ac4cd1#diff-085ccbfcce396237ceea010830b8c75c |
LLVM and SQLite are run-time dependencies. In addition to that this causes installation failures. APT-RPM fails if LLVM and SQLite is not installed before DXR. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
@davidlt I confirm that by cherry-picking 1ac4cd1#diff-085ccbfcce396237ceea010830b8c75c the local build was ok. In particular:
|
|
@Degano , can you please cherry-pick 1ac4cd1#diff-085ccbfcce396237ceea010830b8c75c for IB/CMSSW_8_0_X/stable? |
|
@smuzaffar I can push it here |
|
@smuzaffar @Degano my local branch |
|
@diguida , yes please. thanks |
|
done |
|
Pull request #2147 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
diguida
changed the title
|
It seems that the test failed due to a test setup failure, as the jenkins log reports: |
|
please test |
|
The tests are being triggered in jenkins. |
|
@smuzaffar can we have this merged and available in next IB? We need it to appear in |
|
We are building 8.0.0 today. @davidlange6 , are you OK to get it in? Nothing explicitly depends on it in cmssw. It is just a dependency on cmssw-tool-conf (with out any scram tool file) so that it can be build and upload at the time of release build. |
|
yes, its fine (but would be more appropriate to raise in the release meeting next time
|
New minor version of fasthadd, 2.1, and move llvm sqlite from BuildRequires and Requires for py2-dxr
|
@davidlange6 thanks. Sorry about that: I should have requested it at the ORP meeting, or at least reported in the agenda (the orp-pendig label is there). |
|
BTW I have just added it in the yesterday's agenda, for completeness. |
|
Thanks (but that definitely not my point!)
|
|
@davidlange6's point - all requests for changes in externals should be reported in the ORP agenda and discussed and the ORP meeting - taken! |
|
my fault. I forgot to mention this. |
Define new minor version of
fasthadd, namely 2.1:ROOT 6.0.6, featuring changes in the histogram serialisation;No changes in performance observed or expected.
The new version is required for ease the deployment in the online environment.
@deguio @vanbesien @dmitrijus this is something you might want to watch as well.
Local test failed, but it seems unrelated with this change:
fasthaddRPM was built:This was traced to be an issue with
py2-dxrspecfile. LLVM and SQLite are run-time dependencies. In addition to that this causes installation failures. APT-RPM fails if LLVM and SQLite is not installed before DXR. This is fixed inIB/CMSSW_8_0_X/gcc530branch by 1ac4cd1. This is cherry-picked here.Local tests are now ok, indeed.