Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lightweight classes to apply a trained neural net (lwtnn) #2773

Merged
merged 1 commit into from Jan 17, 2017
Merged

New lightweight classes to apply a trained neural net (lwtnn) #2773

merged 1 commit into from Jan 17, 2017

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/479/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_0_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1

Tested at: cc07391

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2773/479/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/bin/mvaTreeTrainer.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/bin/mvaTreeComputer.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/bin/mvaExtractor.cpp 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/test/testMVATrainerLooper.cc 
/build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/plugins/ProcTMVA.cc: In member function 'void {anonymous}::ProcTMVA::runTMVATrainer()':
/build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/plugins/ProcTMVA.cc:346:11: error: 'std::auto_ptr::element_type {aka class TMVA::Factory}' has no member named 'SetInputTrees'
  factory->SetInputTrees(treeSig, treeBkg);
           ^
/build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/CMSSW_9_0_X_2017-01-16-2300/src/PhysicsTools/MVATrainer/plugins/ProcTMVA.cc:350:12: error: 'std::auto_ptr::element_type {aka class TMVA::Factory}' has no member named 'AddVariable'
   factory->AddVariable(iter->c_str(), 'D');
            ^


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/481/console

@smuzaffar smuzaffar merged commit 63294e0 into cms-sw:IB/CMSSW_9_0_X/gcc530 Jan 17, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2773/481/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants