Create prefix directories before calling pip #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`create_home_path` from `lib/python2.7/distutils/command/install.py` is
responsible for creating prefix (part of installation) directory. By default
it's created with 0700 permission, instead of default umask 0755. According to
Python documention mode while creating directories can be ignored on some
systems thus one should always use os.chmod to set correct permission afterwards.
If prefix directories are created with 0700 we will get conflicts from RPM
while trying to install pip based packages.
We use `mkdir -p %{i}` to create prefix directory with correct umask to get 0755
permissions.
Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
|
A new Pull Request was created by @davidlt for branch IB/CMSSW_9_0_X/gcc530. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_home_pathfromlib/python2.7/distutils/command/install.pyisresponsible for creating prefix (part of installation) directory. By default
it's created with 0700 permission, instead of default umask 0755. According to
Python documention mode while creating directories can be ignored on some
systems thus one should always use os.chmod to set correct permission afterwards.
If prefix directories are created with 0700 we will get conflicts from RPM
while trying to install pip based packages.
We use
mkdir -p %{i}to create prefix directory with correct umask to get 0755permissions.
Signed-off-by: David Abdurachmanov david.abdurachmanov@gmail.com