Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf.spec #2887

Merged
merged 1 commit into from Mar 7, 2017
Merged

Conversation

davidlange6
Copy link
Contributor

clarify the documentation for updating protobuf

clarify the documentation for updating protobuf
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_9_1_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18194/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

-1

Tested at: ed3dfe2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2887/18194/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

@smuzaffar smuzaffar merged commit f1778fb into IB/CMSSW_9_1_X/gcc530 Mar 7, 2017
@smuzaffar smuzaffar deleted the davidlange6-patch-1 branch March 7, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants