added OpenMPI support for sherpa #3108
Conversation
|
A new Pull Request was created by @pmillet for branch IB/CMSSW_9_2_X/gcc700. @cmsbuild, @smuzaffar, @mrodozov, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
| @@ -0,0 +1,25 @@ | |||
| ### RPM external autotools-toolfile 1.0 | |||
There was a problem hiding this comment.
Why do yo need this toolfile?
There was a problem hiding this comment.
I copied this toolfile from the 53X PR. I can see if it works without.
| @@ -0,0 +1,29 @@ | |||
| --- a/config/orte_check_lsf.m4 2017-05-10 17:40:48.000000000 +0200 | |||
There was a problem hiding this comment.
Was this patch upstreamed? If yes, please make sure that SPEC file or/and filename contains revision information. This will help us track the need of this patch next time we bump OpenMPI.
There was a problem hiding this comment.
I got the patch from open-mpi/ompi#3546
openmpi.spec has the tarball version for openmpi included
the patch is has the version number in the name
is this the revision information you had in mind?
| <lib name="mca_common_sm"/> | ||
| <lib name="mpi"/> | ||
| <lib name="mpi_cxx"/> | ||
| <lib name="mpi_f77"/> |
There was a problem hiding this comment.
Do you really need all of this? Especially Fortran 77 and 90 interfaces? Try to keep it bare minimum and disable what's not needed/relevant.
There was a problem hiding this comment.
As above this is copied from the 53X PR. I'll see if it works without.
| @@ -15,6 +15,18 @@ Requires: openloops | |||
| %endif # isamd64 | |||
| %endif # islinux | |||
|
|
|||
| %if "%{?cms_cxx:set}" != "set" | |||
There was a problem hiding this comment.
|
Could you also tell us more about the testing (incl. it's environment) you have done? |
|
I tested building sherpa using ARCH=slc6_amd64_gcc700 with CMSSW=CMSSW_9_2_ROOT6_X (this also builds openmpi). |
|
cmsbuild, please test |
|
The tests are being triggered in jenkins. |
| @@ -3,7 +3,7 @@ | |||
| %define branch cms/v%realversion | |||
| %define github_user cms-externals | |||
| Source: git+https://github.com/%github_user/%{n}.git?obj=%{branch}/%{tag}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}-%{tag}.tgz | |||
| Requires: hepmc lhapdf blackhat sqlite fastjet openssl scons python | |||
| Requires: hepmc lhapdf blackhat sqlite fastjet openssl scons python openmpi | |||
There was a problem hiding this comment.
we should add this dependency for slc*_amd64_gcc700
| @@ -35,6 +35,7 @@ cat << \EOF_TOOLFILE >%i/etc/scram.d/sherpa.xml | |||
| <use name="blackhat"/> | |||
| <use name="fastjet"/> | |||
| <use name="sqlite"/> | |||
| <use name="openmpi/"/> | |||
There was a problem hiding this comment.
this should also be added if sherpa with build with openmpi
|
After all the comments could you redo the PR for DEVEL IBs (gcc630next branch IIRC)? There is no need gcc700 branch (just re-gen the build scripts). |
|
so could we instead push things into mainstream?
… On Jun 19, 2017, at 1:28 PM, davidlt ***@***.***> wrote:
After all the comments could you redo the PR for DEVEL IBs (gcc630next branch IIRC)? There is no need gcc700 branch (just re-gen the build scripts).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
the openmpi patch needs the updated automake |
|
No, the build script generator clearly states that automake 1.12.2 is just fine. As discussed in the tickets, just force regeneration of all build scripts. |
|
Comparison job queued. |
|
I got a new branch with requested fixes ready. Should I open a new PR for a different branch (e.g. gcc630next) ? |
|
@pmillet , yes please. |
|
superseded by #3114 |
Adds openmpi support to Sherpa as requested in cms-sw/cmssw#18174