New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated root 6.10.01 for normal 93X IB #3145
Conversation
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_3_X/gcc530. @cmsbuild, @smuzaffar, @mrodozov, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
The tests are being triggered in jenkins. |
-1 Tested at: 145a64a The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:63: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/lexical_cast/detail/inf_nan.hpp:34: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/math/special_functions/sign.hpp:16: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/math/tools/config.hpp:388: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/detail/fenv.hpp:97: /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:58:11: error: no member named 'fenv_t' in the global namespace using ::fenv_t; ~~^ /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:59:11: error: no member named 'fexcept_t' in the global namespace using ::fexcept_t; ~~^ The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
-1 Tested at: 145a64a The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:63: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/lexical_cast/detail/inf_nan.hpp:34: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/math/special_functions/sign.hpp:16: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/math/tools/config.hpp:388: In file included from /cvmfs/cms-ib.cern.ch/nweek-02479/slc6_amd64_gcc530/external/boost/1.63.0-mlhled2/include/boost/detail/fenv.hpp:97: /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:58:11: error: no member named 'fenv_t' in the global namespace using ::fenv_t; ~~^ /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:59:11: error: no member named 'fexcept_t' in the global namespace using ::fexcept_t; ~~^ The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The tests are being triggered in jenkins. |
Comparison job queued. |
Hi @smuzaffar -seems we can go ahead with this? The PythonAnalysis unit test failure looks real - but presumably fixable. |
yes this looks ok now. I shall merge it just before 23h00 IB to avoid normal cmssw PR tests picking up cms-sw/cmssw@dadb48b without having new root. |
sounds good- -could you also add the one line change I proposed yesterday (which looks to be fine)
… On Jul 6, 2017, at 12:21 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
yes this looks ok now. I shall merge it just before 23h00 IB to avoid normal cmssw PR tests picking up ***@***.*** without having new root.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I am going to test that change (now) first in root6 IBs just to make sure that it does not break anything for root 6.10.01. |
as requested by @davidlange6 here #3148
Pull request #3145 was updated. |
also needs cmssw change