Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pythia8 lhapdf interface and pdfsets.index #3340

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Aug 8, 2017

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_9_2_X/gcc530.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

backport of #3173
and #3324

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22146/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison job queued.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_2_X/gcc530 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3340/22146/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 15028
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1776580
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@perrozzi
Copy link

Hi, is there any specific reason why this PR missed CMSSW_9_2_9 ?
If not, and in any case, could it please be merged asap unless there is a problem?
Thanks a lot in advance

@smuzaffar smuzaffar merged commit 6bd73fa into cms-sw:IB/CMSSW_9_2_X/gcc530 Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants