Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied clang-tidy on thepeg #3387

Merged
merged 1 commit into from Sep 7, 2017
Merged

Conversation

smuzaffar
Copy link
Contributor

Applied clang-tidy changes provided here cms-sw/cmssw#20237 (comment) by @alberto-sanchez

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22769/console

@smuzaffar
Copy link
Contributor Author

tests looks good for gcc700. So merging it for 11h00 IBs.

@smuzaffar smuzaffar merged commit eb6f7a7 into IB/CMSSW_9_4_X/gcc630 Sep 7, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

backport done
Successfully backported PR #3387 as #3389 for branch IB/CMSSW_9_3_X/gcc630

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3387/22769/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 201
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642050
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch September 9, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants