Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pythia8 to 230 #3490

Merged
merged 1 commit into from Oct 24, 2017
Merged

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23722/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@perrozzi
Copy link

@mkirsano may I ask why --with-boost=${BOOST_ROOT} was removed? Not necessary anymore?

@mkirsano
Copy link
Contributor Author

boost and the argument with LHAPDF6.h are no more needed, it is in the release notes

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3490/23722/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12471 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 110648
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2656226
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23759/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 898138e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3490/23759/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step4

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step4_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@alberto-sanchez
Copy link
Member

This fail seems unrelated.

@perrozzi
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23830/console

@perrozzi
Copy link

@mkirsano @alberto-sanchez you can launch yourself the tests too

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3490/23830/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12384 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2793415
  • DQMHistoTests: Total failures: 104960
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2688282
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@smuzaffar smuzaffar merged commit c327e08 into cms-sw:IB/CMSSW_9_4_X/gcc630 Oct 24, 2017
@perrozzi
Copy link

@mkirsano can you please backport to 93x?

@davidlange6
Copy link
Contributor

@alberto-sanchez
Copy link
Member

working on that

@alberto-sanchez
Copy link
Member

Looks like a new contribution was added to the Onia Processes.
g g -> ccbar(3S1)[3S1(1)] gamma 441
In this case, we need to update the JpsiMM_Pt_20_inf_8TeV_TuneCUETP8M1_cfi in cmssw
For the manual:

New processes for 3S1 charmonium or bottomonium production in association with a photon, accessible through the new switches Charmonium:gg2ccbar(3S1)[3S1(1)]gm and Bottomonium:gg2ccbar(3S1)[3S1(1)]gm.

I will create a PR to fix the appropiated cfgs.

@alberto-sanchez
Copy link
Member

cms-sw/cmssw#21047

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants