Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keras to 2.1.2 #3625

Merged
merged 1 commit into from Dec 14, 2017
Merged

Conversation

mrodozov
Copy link
Contributor

Update keras and leave the default backend untouched (tensorflow instead of theano)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov for branch IB/CMSSW_10_0_X/gcc630next.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25047/console

@cmsbuild
Copy link
Contributor

-1

Tested at: b5400b9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3625/25047/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTheano had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3625/25047/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3625/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21683 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835241
  • DQMHistoTests: Total failures: 105064
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 2729994
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.34000000011 KiB( 23 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2017

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#21698
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25075/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mrodozov
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_0_X/gcc630next IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c5a5adf into IB/CMSSW_10_0_X/gcc630next Dec 14, 2017
@cmsbuild cmsbuild mentioned this pull request Dec 14, 2017
@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #3625 as #3632 for branch IB/CMSSW_10_0_X/gcc630

@smuzaffar smuzaffar deleted the update-keras-212 branch December 21, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants