include cms_oracleocci_abi_hack/include directory

[smuzaffar]

cms_oracleocci_abi_hack now includes occi.h with either contents of

• https://github.com/cms-sw/cms_oracleocci_abi_hack/blob/master/cms_oracleocci_old_abi.h if we have OLD ABI. This contains inline functions for getOraString and getOraMessage
• https://github.com/cms-sw/cms_oracleocci_abi_hack/blob/master/cms_oracleocci_cxx11_abi.h if we have new cxx11 ABI. This provide out of line implementation via cms_oracleocci_abi_hack for getOraString and getOraMessage

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26007/console

[cmsbuild]

-1

Tested at: 25a6e44

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3733/26007/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-10-1100/src/OnlineDB/SiStripConfigDb/test/plugins/module.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-10-1100/src/OnlineDB/SiStripConfigDb/test/plugins/testSiStripConfigDb.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-10-1100/src/OnlineDB/SiStripConfigDb/src/SiStripDbParams.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-10-1100/src/OnlineDB/Oracle/test/test.cpp:5:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/cms/cms_oracleocci_abi_hack/20180210/include/occi.h: In function 'const char* getOraString(oracle::occi::Statement*, int)':
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/cms/cms_oracleocci_abi_hack/20180210/include/occi.h:7:27: error: base operand of '->' has non-pointer type 'std::string {aka std::basic_string}'
   return obj->getString(n)->c_str();
                           ^~
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/cms/cms_oracleocci_abi_hack/20180210/include/occi.h: In function 'const char* getOraString(oracle::occi::ResultSet*, int)':
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/cms/cms_oracleocci_abi_hack/20180210/include/occi.h:12:27: error: base operand of '->' has non-pointer type 'std::string {aka std::basic_string}'
   return obj->getString(n)->c_str();


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #3733 was updated.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26009/console

[cmsbuild]

+1
Tested at: e908e80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3733/26009/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3733/26009/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3733/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2464162
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2463992
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.0499999999 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files