Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CUDA compilation flags #3786

Merged
merged 1 commit into from Mar 2, 2018
Merged

Update CUDA compilation flags #3786

merged 1 commit into from Mar 2, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 1, 2018

Update the default CUDA flags to include -O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 1, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard fwyzard mentioned this pull request Mar 1, 2018
Closed
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Mar 1, 2018
@fwyzard
Remove -O2/-O3 from CUDA flags
c28c8ae 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
@fwyzard fwyzard mentioned this pull request Mar 1, 2018
Merged
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Mar 1, 2018
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
6556015 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 1, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26403/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

+1
Tested at: a4fea15
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/26403/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/26403/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.980000000054 KiB( 21 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 1, 2018

@smuzaffar could you merge this ?
I've tested it on our GU development branch as well.

@fabiocos are we still in time to get this in pre2 ?

@smuzaffar smuzaffar merged commit 0912a24 into cms-sw:IB/CMSSW_10_1_X/gcc630 Mar 2, 2018
@smuzaffar
Copy link
Contributor

pre2 is already uploaded

@fabiocos
Copy link
Contributor

fabiocos commented Mar 2, 2018

@fwyzard no, pre2 was closed already

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2018 via email

@fwyzard fwyzard deleted the CUDA_flags_for_IB/CMSSW_10_1_X/gcc630 branch May 22, 2018 13:30
@fwyzard fwyzard restored the CUDA_flags_for_IB/CMSSW_10_1_X/gcc630 branch May 22, 2018 13:30
@fwyzard fwyzard deleted the CUDA_flags_for_IB/CMSSW_10_1_X/gcc630 branch May 22, 2018 13:30
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 8, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
9b5f1d7 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 19, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
a34139b 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
a232209 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
e76aa33 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
d46d528 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
22f43a7 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Remove -O2/-O3 from CUDA flags (#29)
e556c20 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
@fwyzard
Remove -O2/-O3 from CUDA flags (#29)
e8cc5ff 
After cms-sw/cmsdist#3786 the default CUDA flags are set to
`-O3 -std=c++14 --expt-relaxed-constexpr --expt-extended-lambda` .

Since `nvcc` does not support multiple `-On` options on the command
line, remove them from the `CUDA_FLAGS` set in the BuildFile.xml .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @smuzaffar @fabiocos