Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack CUDA to support GCC 7 #3962

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 26, 2018

First, patch CUDA headers not to reject GCC 7.

Then, force the host compiler to use C++14 for CUDA code, because with GCC 7 we cannot safely mix C++17 preprocessing with C++14 compilations.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 26, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27674/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 6a4d685

  • Build:

I found an error when building:

+ rm -rf /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc630/external/cuda/9.1.85-cms2/lib64/libcublas.so.9.1.128
+ rm -rf /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc630/external/cuda/9.1.85-cms2/lib64/libnvblas.so.9.1.128
+ %patch0 -p1
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.r6bv1r: line 62: fg: no job control
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.r6bv1r (%install)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.r6bv1r (%install)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3962/27674/summary.html

@cmsbuild
Copy link
Contributor

Pull request #3962 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 26, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27675/console

@cmsbuild
Copy link
Contributor

-1

Tested at: eb7302a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3962/27675/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

ImportError: /cvmfs/cms-ib.cern.ch/nweek-02521/slc6_amd64_gcc630/lcg/root/6.10.09-hkdhhm/lib/libPyROOT.so: undefined symbol: _ZN11TBufferFile14WriteObjectAnyEPKvPK6TClass
gmake: *** [tmp/slc6_amd64_gcc630/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
Suggestion: You can run 'scram build updateclassversion' to generate src/CalibFormats/CaloObjects/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/slc6_amd64_gcc630/edm_checks/libCalibFormatsCaloObjects.so] Error 1
>> EDM Checks sequence completed for CMSSW CMSSW_10_2_X_2018-04-26-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 27, 2018 via email

@smuzaffar
Copy link
Contributor

please test
@fwyzard , the error is due to the fact that we updated rot to 6.12 (which is not yet part of the IB but is merged in cmsdist). Last night IB has the new root. I have restarted the test which should use the new IB

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27682/console

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 27, 2018 via email

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar smuzaffar merged commit a6851de into cms-sw:IB/CMSSW_10_2_X/gcc630 Apr 27, 2018
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3962/27682/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2495054
  • DQMHistoTests: Total failures: 2032
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492846
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 27, 2018

Hi @smuzaffar ,
could you let me know when the SCRAM rules are updated as well ?

Thank you,
.A

@smuzaffar
Copy link
Contributor

@fwyzard , sorry not yet. Will do it later in the evening.

@fwyzard fwyzard deleted the IB/CMSSW_10_2_X/gcc630_CUDA_GCC7 branch May 3, 2018 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants