Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[94X] Updated fastjet-contrib: Inculded EnergyCorrelator in v1.026 #3969

Merged
merged 1 commit into from
May 9, 2018

Conversation

smuzaffar
Copy link
Contributor

copied EnergyCorrelator files from v1.033 on top of v1.026
cms-externals/fastjet-contrib#17

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27730/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3969/27730/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721229
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@smuzaffar
Copy link
Contributor Author

@fabiocos , FYI

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit a70454f into IB/CMSSW_9_4_X/gcc630 May 9, 2018
@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch May 10, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants