Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.4.X] PhysicsTools-NanoAOD: btag weights and bregression training for nanoaod #4078

Merged
merged 1 commit into from Jun 4, 2018

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 4, 2018

backport of #4077

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28404/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4078/28404/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721223
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@smuzaffar
Copy link
Contributor Author

merging it as it contains only new files

@smuzaffar smuzaffar merged commit acb889f into IB/CMSSW_9_4_X/gcc630 Jun 4, 2018
@smuzaffar smuzaffar deleted the smuzaffar-patch-3 branch June 4, 2018 06:44
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

-1

Tested at: a507429

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
871a09d
04c80e4
b01ec5e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4078/28429/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4078/28429/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23445/28429/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
871a09d
04c80e4
b01ec5e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4078/28429/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4078/28429/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#23445
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28447/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison job queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants