Dire 2.002

[mseidel42]

Updating Dire to version 2.002

DIRE-2.002.tar.gz release dated 2018/06/05. This version improves the handling of resonance showers, and is important for e.g. a correct handling of top production & decay. Code changes beyond resonance showers are preliminary, switched off by default, not endorsed by the authors, and not checked for correctness.

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28464/console

[cmsbuild]

+1
Tested at: c814a72
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4090/28464/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4090/28464/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902471
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902279
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@fabiocos , any objection on merging this?

[fabiocos]

@intrepid42 @alberto-sanchez how was this code really tested? I mean which specific workflow using it was tried?

[mseidel42]

Hi Fabio, this is the test configuration: https://github.com/cms-sw/cmssw/blob/master/GeneratorInterface/Pythia8Interface/test/pythia8ex14_cfg.py

[fabiocos]

@intrepid42 thanks, this does not run in the regular PR checks, I assume it has been tried in a standalone way, right?

[mseidel42]

Yes, exactly.

How can we include it in the regular checks? Is it like this?

• Add generator fragment as Configuration/Generator/python/Process_xTeV_dire_cff.py (ANy preference whether the process should be LHC or LEP (faster)?)
• Add steps['Process_xTeV_dire']=genvalid('Process_xTeV_dire_cff',step1GenDefaults) to relval_steps.py
• Add workflows[5xx]=['',['Process_xTeV_dire','HARVESTGEN']] to relval_steps.py

[fabiocos]

@intrepid42 @fabozzi @prebello adding a new Relval test for Dire makes sense to me if it is a code that we want to massively use. For the purpose of this integration the standalone positive test should be enough

[fabiocos]

+1