Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eigen to leverage the latest updates to CUDA and AVX support #4173

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 6, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 7, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29040/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4173/29040/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899288
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@fwyzard , do you understand why the latest commit here https://github.com/cms-externals/eigen-git-mirror/tree/cms/64060da is 64060da while if you click on commits of this branch then there are many other commits on top of it?

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 7, 2018 via email

@smuzaffar smuzaffar merged commit 74aa511 into cms-sw:IB/CMSSW_10_2_X/gcc630 Jul 13, 2018
@fwyzard fwyzard deleted the IB/CMSSW_10_2_X/gcc630_update_eigen branch August 28, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants