Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-RecoBTag-Combined.spec #4176

Merged
merged 1 commit into from Jul 13, 2018

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jul 9, 2018

@mrodozov
Copy link
Contributor Author

mrodozov commented Jul 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29046/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4176/29046/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899490
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899292
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

slava77 added a commit to slava77/cmsdist that referenced this pull request Jul 11, 2018
@slava77
Copy link
Contributor

slava77 commented Jul 13, 2018

@mrodozov @smuzaffar
please merge this or comment if some changes are necessary.
This PR data files were already successfully tested at run time (as a part of #4176).
Thank you.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar
Copy link
Contributor

@slava77 , we are fine to merge it but as cms-data/RecoBTag-Combined#15 updates couple of existing files so assigned reco to sign it too.

@smuzaffar
Copy link
Contributor

oops sorry, all files are new (I was looking in to master branch). So forget my previous comment.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cms-sw cms-sw deleted a comment from cmsbuild Jul 13, 2018
@smuzaffar smuzaffar merged commit 6625b1c into IB/CMSSW_10_2_X/gcc630 Jul 13, 2018
@smuzaffar smuzaffar deleted the mrodozov-patch-2 branch July 18, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants