Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building all FxFx libraries including the ones required for FxFx #4499

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

Andrej-CMS
Copy link
Contributor

Dear all,
this is required to use the whole matching and merging framework of Herwig7.

Kind regards,
Andrej

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Andrej-CMS for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31650/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4499/31650/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 37
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013077
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals
FYI @fabiocos

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@Andrej-CMS @alberto-sanchez how was this practically tested?

@Andrej-CMS
Copy link
Contributor Author

@fabiocos

I ran it with my local build and cms-sw/cmssw#25180 with a corresponding FxFx config

@fabiocos
Copy link
Contributor

@Andrej-CMS and got a meaningful output?

@fabiocos fabiocos closed this Nov 15, 2018
@fabiocos fabiocos reopened this Nov 15, 2018
@Andrej-CMS
Copy link
Contributor Author

@fabiocos

I cannot comment on the physics, for this I would need to produce much more events. However, technically the FxFx merging with these libraries works

@fabiocos
Copy link
Contributor

@Andrej-CMS ok thanks, for a physics validation you need a release to produce larger samples

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c844cf3 into cms-sw:IB/CMSSW_10_4_X/gcc700 Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants