-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building all FxFx libraries including the ones required for FxFx #4499
building all FxFx libraries including the ones required for FxFx #4499
Conversation
A new Pull Request was created by @Andrej-CMS for branch IB/CMSSW_10_4_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@Andrej-CMS @alberto-sanchez how was this practically tested? |
I ran it with my local build and cms-sw/cmssw#25180 with a corresponding FxFx config |
@Andrej-CMS and got a meaningful output? |
I cannot comment on the physics, for this I would need to produce much more events. However, technically the FxFx merging with these libraries works |
@Andrej-CMS ok thanks, for a physics validation you need a release to produce larger samples |
+1 |
Dear all,
this is required to use the whole matching and merging framework of Herwig7.
Kind regards,
Andrej