Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.5.X] Updated data-RecoTracker-FinalTrackSelectors V01-00-06 #4516

Merged
merged 6 commits into from
Feb 13, 2019

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#21717
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31779/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#21717
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31823/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#21717
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31876/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #4516 was updated.

@cmsbuild
Copy link
Contributor

-1

Tested at: dea94b4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21717/32509/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #4516 was updated.

@cmsbuild
Copy link
Contributor

Pull request #4516 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Pull request #4516 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#21717
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33021/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4516/33021/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10430 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 16747
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3080490
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.016 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 136.85 ): -0.016 KiB JetMET/SUSYDQM
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Feb 13, 2019

@smuzaffar @mrodozov

I think that this is ready to be merged now.
It's safe to merge by itself.
This external is required for integration of #21717

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_5_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-5 branch February 14, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants