Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dasgoclient version #4524

Merged
merged 1 commit into from
Nov 23, 2018
Merged

New dasgoclient version #4524

merged 1 commit into from
Nov 23, 2018

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Nov 23, 2018

New release includes the following fixes:

  • fix racing condition in x509proxy, too many open files
  • add aggregation function support, e.g. sum(file.nevents)
  • align with recent changes to das2go web server

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31824/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4524/31824/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131631
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar smuzaffar merged commit 4c74d77 into cms-sw:IB/CMSSW_10_4_X/gcc700 Nov 23, 2018
@smuzaffar
Copy link
Contributor

@vkuznet , did you see this issue cms-sw/cmssw#25336
Looks like das client now prints an error message on standard output which breaks a unit test

dasgoclient --query "file dataset=/ZeroBias/Run2018B-SiStripCalMinBias-17Sep2018_pilot-v1/ALCARECO site=T2_CH_CERN | grep file.name"
ERRO[0000] unable to Http client Error="Get https://cms-rucio-authz.cern.ch/auth/x509: remote error: tls: unknown certificate"
/store/data/Run2018B/ZeroBias/ALCARECO/SiStripCalMinBias-17Sep2018_pilot-v1/100000/2092A313-0B8F-CC40-B74F-A2822E1CD1BB.root

can you please provide a fix as soon as possible?

@smuzaffar
Copy link
Contributor

looks like it works now. dasgoclient --query "file dataset=/ZeroBias/Run2018B-SiStripCalMinBias-17Sep2018_pilot-v1/ALCARECO site=T2_CH_CERN | grep file.name" does not show the error line. Was something fixed on rucio server side?

@fabiocos
Copy link
Contributor

@smuzaffar right, the latest IB was clean...

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 27, 2018

right... We still need to fix das client so that in case of server side errors it should not print messages on standard output and break the json format.

@vkuznet
Copy link
Contributor Author

vkuznet commented Nov 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants