Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vecgeom patch for 00.05.00 #4628

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jan 9, 2019

Resolve: #4626

@mrodozov
Copy link
Contributor Author

mrodozov commented Jan 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_5_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

mrodozov commented Jan 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32501/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4628/32501/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153500
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jan 9, 2019

Reco comparison results: 8 differences found in the comparisons

there is apparently nothing relevant related to the update.
Our MC tests with jenkins are only on about 20 sim events.
It looks like the fix for the uninit variable has fairly small impact (at least not affecting every event).

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_5_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@mrodozov mrodozov deleted the vecgeom-patch-for-0005 branch January 10, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants