-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Professor2 and update to 2.2.2 #4668
Conversation
A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_10_5_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Pull request #4668 was updated. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_5_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos , this can be merged. Both professor and professor2 provide separate libs and python packages. Their libs can safely co-exists under LIBDIR. |
+1 @smuzaffar thanks, Professor is a standalone tool that does not enter in production workflows, GEN experts are performing dedicated checks on it |
Need to specify
LIBDIR
to findlibProfessor2.so
. Also updated to 2.2.2 then.