Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Configuration-Generator tag - 7_1 #4762

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Mar 7, 2019

Regarding this request #4761 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@scodella
Copy link

scodella commented Mar 8, 2019

Is any test required for this request?

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33516/console

@fabiocos
Copy link
Contributor

@mrodozov I would like to integrate the master version and this backport, as they are just addition of data files

@cmsbuild
Copy link
Contributor

-1

Tested at: 0ee93b9

  • Build:

I found compilation error when building:

+ case "${DOWNLOAD_TOOL}" in
+ touch V01-00-02.tar.gz
+ curl -L -O -k https://github.com/cms-data/Configuration-Generator/archive/V01-00-02.tar.gz

curl: (35) SSL connect error
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.ZyOytZ (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.ZyOytZ (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4762/33516/summary.html

@scodella
Copy link

does the compilation error message give any hint to you? Is there any action should I take?

@scodella
Copy link

sorry to bother you again on this, but do you think this error can be fixed? Please let me know if I should take any action.

@fabiocos
Copy link
Contributor

please test

to verify whether it was just a temporary issue in the build procedure

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33562/console

@smuzaffar
Copy link
Contributor

I am looking in to it.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33563/console

@cmsbuild
Copy link
Contributor

Pull request #4762 was updated.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4762/33563/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682535
  • DQMHistoTests: Total failures: 3545
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 678616
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@fabiocos
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_7_1_X/stable IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 6b9b1d0 into IB/CMSSW_7_1_X/stable Mar 13, 2019
@smuzaffar smuzaffar deleted the update-Configuration-Generator-tag-7_1 branch March 25, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants