Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Configuration-Generator tag to 01-00-03 #4850

Merged
merged 1 commit into from Apr 12, 2019

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Apr 8, 2019

Description is here: cms-data/Configuration-Generator#6
Resolves: #4830

@mrodozov
Copy link
Contributor Author

mrodozov commented Apr 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34044/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison job queued.

@scodella
Copy link

scodella commented Apr 8, 2019

Thanks for triggering this. We will need this also backported to 7_1_X. Can you please open a request for that (or instruct me how to do that)?

@mrodozov
Copy link
Contributor Author

mrodozov commented Apr 8, 2019

I have to do it manually as for 7_1 we are using different way of doing things which is not backward compatible with what we do now. In most cases you'd just need to copy this PR and change the base branch to say 10_5 and that should be enough.

mrodozov added a commit that referenced this pull request Apr 8, 2019
mrodozov added a commit that referenced this pull request Apr 8, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4850/34044/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

@fabiocos I think this should go into master before the backport is merged

@fabiocos
Copy link
Contributor

@kpedro88 this has to enter in master as well, sure, but as they are just additional input files I do not see much problem in moving in parallel

@fabiocos
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

@mrodozov please approve this one

@mrodozov
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ca80e96 into IB/CMSSW_10_6_X/gcc700 Apr 12, 2019
@smuzaffar smuzaffar deleted the update-Configuration-Generator-tag branch May 3, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cms-data/Configuration-Generator#6: Chargino decay files for additional T2qq and T2tb models
5 participants