Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch v6-14-00-patches #4852

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Apr 8, 2019

No description provided.

@mrodozov
Copy link
Contributor Author

mrodozov commented Apr 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34050/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/rootnext.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

-1

Tested at: 87811f7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4852/34050/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testSchemaEvolution had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4852/34050/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

assign dqm
The schema evolution test is failing for root 6.14 and root master IBs. Looks like it is due to the change root-project/root@94610d9
Can we get this test fixed?

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@andrius-k,@schneiml,@jfernan2,@fioriNTU,@kmaeshima you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Contributor

@rovere , any suggestion to fix this testSchemaEvolution test?

@schneiml
Copy link

@smuzaffar It will need a change to the test to whitelist the new version. This check watches any changes in the ROOT object versions that are relevant for DQMGUI/fastHadd so we are reminded to check and update them if needed.

@schneiml
Copy link

The check tests for version equality as far as I remember, after we had trouble with decreasing version numbers. So we either need to get the ROOT version and test update in at the same time or modify the test logic again.

@mrodozov
Copy link
Contributor Author

get the ROOT version and test update in at the same time

we can do that. Once the cms-sw test is updated (I suppose assign the new numbers) you just test your cms-sw PR with the changes in this PR together. Write the cms-sw PR and share the link to it, I'll start the test.

schneiml added a commit to schneiml/cmsdist that referenced this pull request Apr 16, 2019
Tracking the change in latest CMSSW, commit 87811f7 / PR cms-sw#4852.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26464
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34215/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 87811f7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26464/34215/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test testConditionDatabase_2 had ERRORS

  • RelVals:

The relvals timed out after 4 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26464
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34242/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26464/34242/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar
Copy link
Contributor

merging it for root614 IBs. We have opened a dedicated cmssw branch CMSSW_10_6_ROOT614_X to integrate cms-sw/cmssw#26464

@smuzaffar smuzaffar merged commit f3531f0 into cms-sw:IB/CMSSW_10_6_X/rootnext May 8, 2019
@mrodozov mrodozov deleted the root-update-v6-14-00-patches-20190408 branch May 8, 2019 10:20
@mrodozov mrodozov restored the root-update-v6-14-00-patches-20190408 branch May 8, 2019 10:21
@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #4852 as #4952 for branch IB/CMSSW_10_6_X/gcc700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants