Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initalizing theQuickParticles with nullptr #4881

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

Andrej-CMS
Copy link
Contributor

Dear all,
I made the changes that you proposed and the code did run locally (which it already did before).
I need a version to test it on crab.
Kind regards,
Andrej

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Andrej-CMS for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34219/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4881/34219/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@Andrej-CMS
Copy link
Contributor Author

Dear @ALL
It would be nice to have a testable build of this for crab jobs.
Kind regards,
Andrej

@qliphy
Copy link
Contributor

qliphy commented Apr 23, 2019

@smuzaffar, @gudrutis, @mrodozov Would you please review and sign it? We need to test if for Herwig7 asap. Thanks!

More details can be found in this ticket: https://its.cern.ch/jira/browse/CMSCOMPPR-5075

@mrodozov
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@mrodozov
Copy link
Contributor

you'll need also the release manager to sign it, the near most IB would be today at 23:00.
@fabiocos

@mrodozov mrodozov merged commit d9c8a56 into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 23, 2019
@qliphy
Copy link
Contributor

qliphy commented May 4, 2019

@fabiocos Can you sign it thus we can have a IB to test Herwig7 requests?

@Andrej-CMS may comment more, but the details can be found here:
https://its.cern.ch/jira/browse/CMSCOMPPR-5075

@fabiocos
Copy link
Contributor

fabiocos commented May 4, 2019

@qliphy this was merged 11 days ago...

@qliphy
Copy link
Contributor

qliphy commented May 4, 2019

Ok, thanks. I saw ORP still pending and misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants