-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initalizing theQuickParticles with nullptr #4881
Conversation
A new Pull Request was created by @Andrej-CMS for branch IB/CMSSW_10_6_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Dear @ALL |
@smuzaffar, @gudrutis, @mrodozov Would you please review and sign it? We need to test if for Herwig7 asap. Thanks! More details can be found in this ticket: https://its.cern.ch/jira/browse/CMSCOMPPR-5075 |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
you'll need also the release manager to sign it, the near most IB would be today at 23:00. |
@fabiocos Can you sign it thus we can have a IB to test Herwig7 requests? @Andrej-CMS may comment more, but the details can be found here: |
@qliphy this was merged 11 days ago... |
Ok, thanks. I saw ORP still pending and misunderstood. |
Dear all,
I made the changes that you proposed and the code did run locally (which it already did before).
I need a version to test it on crab.
Kind regards,
Andrej