Updated root to tip of branch v6-14-00-patches (cmsdist master)

[mrodozov]

No description provided.

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/894/console Started: 2019/06/12 01:04

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[cmsbuild]

-1

Tested at: b24dbe4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec53d8/894/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test ExpressionEvaluatorUnitTest had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec53d8/894/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215123
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[smuzaffar]

+externals
the failing unit tests mostly hangs during PR testing but it works in IBs.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@fabiocos @Dr15Jones, this udpates root 6.14 for normal IBs. This brings in following changes

root-project/root@84a781a...5e217f2

Feel free to merge it

[Dr15Jones]

I don't believe any production jobs make use of TTreeFormula so it seems unlikely to break any production.

[fabiocos]

@Dr15Jones @smuzaffar within CMSSW this is just used in macros of HLTriggerOffline/Egamma, and within Fireworks https://cmssdt.cern.ch/lxr/source/Fireworks/Core/src/FWTSelectorToEventList.cc#0006 (not clear to me where this is really used).

Is the unit test failure reproducible?

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/926/console Started: 2019/06/12 21:55

[cmsbuild]

+1
Tested at: b24dbe4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec53d8/926/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec53d8/926/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254096
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3253761
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[smuzaffar]

@fabiocos , we can include this too for next IB

[fabiocos]

+1