Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivet 3.0.1 #5107

Merged
merged 8 commits into from Aug 13, 2019
Merged

Conversation

mseidel42
Copy link
Contributor

@mseidel42 mseidel42 commented Jul 25, 2019

New major Rivet release, needs upgrade of RivetInterface: cms-sw/cmssw#27610

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27610
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1642/console Started: 2019/07/25 19:54

@cmsbuild
Copy link
Contributor

-1

Tested at: 2a6e33d

  • Build:

I found compilation error when building:

* The action "install-external+thepeg-toolfile+2.1-cms" was not completed successfully because The following dependencies could not complete:
build-external+thepeg-toolfile+2.1-cms
* The action "install-external+madgraph5amcatnlo+2.6.0-cms" was not completed successfully because The following dependencies could not complete:
build-external+madgraph5amcatnlo+2.6.0-cms
* The action "build-external+thepeg+2.1.4-cms" was not completed successfully because Failed to build thepeg. Log file in /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/thepeg/2.1.4-cms/log. Final lines of the log file:
NLORivetAnalysis.cc:252:70: error: no matching function for call to 'Rivet::AnalysisHandler::setCrossSection(ThePEG::Qty<0, 0, 0, 1, 1, 1>, ThePEG::Qty<0, 0, 0, 1, 1, 1>)'
generator()->integratedXSecErr()/picobarn);
^
In file included from NLORivetAnalysis.h:9:0,
from NLORivetAnalysis.cc:7:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/rivet/3.0.1/include/Rivet/AnalysisHandler.hh:90:10: note: candidate: void Rivet::AnalysisHandler::setCrossSection(std::pair)


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f974d/1642/summary.html

@mseidel42
Copy link
Contributor Author

Oh, that comes unexpected. I would suggest to compile ThePEG without Rivet. There should not be any need for calling Rivet analyses directly from the the Herwig7 configuration, it can all be passed to the RivetInterface.

@cmsbuild
Copy link
Contributor

Pull request #5107 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 26, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27610
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1651/console Started: 2019/07/26 11:27

@cmsbuild
Copy link
Contributor

-1

Tested at: 4bed613

  • Build:

I found compilation error when building:

* The action "install-cms+cmssw-tool-conf+45.0-cms" was not completed successfully because The following dependencies could not complete:
build-cms+cmssw-tool-conf+45.0-cms
* The action "build-external+herwigpp+7.1.4-cms" was not completed successfully because Failed to build herwigpp. Log file in /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/herwigpp/7.1.4-cms/log. Final lines of the log file:
In file included from FxFxEventHandler.h:18:0,
from FxFxReader.cc:31:
FxFxAnalysis.h:9:10: fatal error: Rivet/AnalysisHandler.hh: No such file or directory
#include "Rivet/AnalysisHandler.hh"
^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [FxFxReader.o] Error 1
In file included from FxFxEventHandler.h:18:0,


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f974d/1651/summary.html

@cmsbuild cmsbuild merged commit fe7de33 into cms-sw:IB/CMSSW_11_0_X/gcc700 Aug 13, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27691
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2002/console Started: 2019/08/13 14:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 49441db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b065d/2002/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #27610 @intrepid42: Update RivetInterface for Rivet 3.x

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b065d/2002/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b065d/2002/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27634,#5120,cms-data/RecoHGCal-TICL#1
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2004/console Started: 2019/08/13 18:32

@cmsbuild
Copy link
Contributor

-1

Tested at: 49441db

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8631ff/2004/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc:19:0:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:65:25: error: 'GenParticle' does not name a type; did you mean 'Particle'?
     bool hasChild(const GenParticle *ptcl, int pdgID) {
                         ^~~~~~~~~~~
                         Particle
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:73:26: error: 'GenParticle' does not name a type; did you mean 'Particle'?
     bool hasParent(const GenParticle *ptcl, int pdgID) {

  • Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc:19:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:65:25: error: unknown type name 'GenParticle'; did you mean 'HepMC::GenParticle'?
    bool hasChild(const GenParticle *ptcl, int pdgID) {
                        ^~~~~~~~~~~
                        HepMC::GenParticle
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/hepmc/2.06.07-pafccj/include/HepMC/IO_GenEvent.h:25:7: note: 'HepMC::GenParticle' declared here
class GenParticle;


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b065d/2002/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939161
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants