Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenLoops] Revert "build openloops for x86_64 arch only" #5232

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

smuzaffar
Copy link
Contributor

Reverts #5221

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with #5231 for slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #5231
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2538/console Started: 2019/09/16 23:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

please test for slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2554/console Started: 2019/09/18 10:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

please test
starting tests for master IBs.

This looks good now, openloops was successfully build for aarch64
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb06a4/2554/external/openloops/2.1.0-eb06a4/log

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2563/console Started: 2019/09/18 16:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb06a4/2563/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957336
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956994
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals
@fabiocos , this is ready to go in, it just enable openloop for aarch64 builds

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

so let's give it a try

@cmsbuild cmsbuild merged commit 0026ab3 into IB/CMSSW_11_0_X/master Sep 18, 2019
@smuzaffar smuzaffar deleted the revert-5221-openloops-x86_64 branch September 19, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants