Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow sys_platform based package selection for pip packages #5263

Merged
merged 1 commit into from
Oct 7, 2019
Merged

allow sys_platform based package selection for pip packages #5263

merged 1 commit into from
Oct 7, 2019

Conversation

smuzaffar
Copy link
Contributor

this change allow to have different package version for different sys_platforms

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2812/console Started: 2019/10/07 12:45

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

jenkins tests looks good. merging it to get aarch64 IB

@smuzaffar smuzaffar merged commit d791cf2 into IB/CMSSW_11_0_X/master Oct 7, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

+1
Tested at: 29cb641
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b35f6/2812/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b35f6/2812/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961052
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960710
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar smuzaffar deleted the pip-sys_platform branch October 7, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smuzaffar @cmsbuild