Revert "Enable DataFormats & FWCore C++ modules for CMSSW" #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_0_X/rootmodule. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
smuzaffar
reviewed
Oct 30, 2019
scram-project-build.file
Outdated
| @@ -64,7 +64,7 @@ Requires: glibc | |||
| %endif | |||
|
|
|||
| %if "%{?configtag:set}" != "set" | |||
| %define configtag V05-09-15 | |||
| %define configtag V05-09-14 | |||
There was a problem hiding this comment.
@davidlange6 , we need to keep this in IB.
|
Pull request #5316 was updated. |
|
Thanks for fixing this up Shahzad
On 30 Oct 2019, at 22:18, Malik Shahzad Muzaffar <notifications@github.com> wrote:
Merged #5316<#5316> into IB/CMSSW_11_0_X/rootmodule.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5316?email_source=notifications&email_token=ABGPFQ76G3KXWPUZCOE5S73QRH2WPA5CNFSM4JGZQ5W2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOURPPRLI#event-2757687469>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQYMR6XNJMJENVH3MULQRH2WPANCNFSM4JGZQ5WQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5284
we've understood that there is at least one more issue to fix before enabling this in the IB