Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenLoops-2.1.0]Topping up Vtt+jets and Htt+jets libraries processes #5327

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Nov 4, 2019

lhc.coll does not contain all P-P collision processes. Topping up Vtt+Jets and Htt+jets loop processes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test for slc7_aarch64_gcc820
In past we had issue ( #5215 (comment) ) for aarch64. We need to check if enabling these extra libs will cause the same big library issue.

@SiewYan , is it possible to build multiple small shared libs for openloops?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3324/console Started: 2019/11/04 10:06

@SiewYan
Copy link
Contributor Author

SiewYan commented Nov 4, 2019

@smuzaffar , yes, the LHC.coll is a pre-defined collection of small shared libs, and it should work, if not, I will have to pre-define a txt file with .coll extension specifying each process's library names.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Comparison job queued.

@smuzaffar
Copy link
Contributor

please test workflow 534.0,536.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3328/console Started: 2019/11/04 15:12

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

-1

Tested at: cac8509

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edd662/3328/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testPYDablooms had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edd662/3328/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-edd662/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-edd662/536.0_sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938683
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

please test workflow 534.0,536.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3335/console Started: 2019/11/04 21:12

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edd662/3335/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-edd662/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-edd662/536.0_sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938684
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 5, 2019

+1

@cmsbuild cmsbuild merged commit eb29772 into cms-sw:IB/CMSSW_11_0_X/master Nov 5, 2019
@SiewYan SiewYan deleted the upmaster branch November 5, 2019 10:29
@SiewYan
Copy link
Contributor Author

SiewYan commented Nov 18, 2019

Hello @smuzaffar , I have a followup question on the Openloops's libraries processes. There is a growing interest in using other libraries processes, one way is to manually include all the libraries processes by defining a txt file and take in as an argument during compilation https://github.com/SiewYan/cmsdist/blob/cac85098983d7c2f0ff15444d71054f60c534deb/openloops.spec#L26
It is possible to do so in cmsdist, creating a txt file in cmsdist and compile?
Thanks

@fabiocos
Copy link
Contributor

@SiewYan do you want to provide the txt as an external input? I can imagine it could be hardcoded into the spec file itself. One question I have is: how big would the proclib repository become? It is already larger than 3 GB

@SiewYan
Copy link
Contributor Author

SiewYan commented Nov 24, 2019

@fabiocos , yes, to manually defined problib.
It is a lengthy list if one hardcorded it.
I have installed user.coll defined for backport on 93X [*], it will take ~ 13 GB.

[*] #5369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants