[DD4Hep] Updated to get conversion for Polyhedra and Polycone fix

[smuzaffar]

Resolves #5341
AIDASoft/DD4hep#578

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3412/console Started: 2019/11/10 16:13

[cmsbuild]

-1

Tested at: 2e77ed0

• Build:

I found compilation error when building:

1 out of 1 hunk FAILED -- saving rejects to file DDG4/CMakeLists.txt.rej
patching file cmake/DD4hepBuild.cmake
Hunk #1 FAILED at 613.
Hunk #2 FAILED at 623.
2 out of 2 hunks FAILED -- saving rejects to file cmake/DD4hepBuild.cmake.rej
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7Npnsb (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7Npnsb (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07129d/3412/summary.html

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3413/console Started: 2019/11/10 18:36

[cmsbuild]

Pull request #5342 was updated.

[cmsbuild]

+1
Tested at: e29d86f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07129d/3413/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07129d/3413/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 26
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2935993
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3419/console Started: 2019/11/11 07:36

[cmsbuild]

+1
Tested at: e29d86f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07129d/3419/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07129d/3419/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 28
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2935991
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@smuzaffar @kpedro88 @ianna the DQM differences looks unrelated to this PR, linked to #28367

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1