openloops 2.1.0 feed in user defined loop process libraries

[SiewYan]

feed in user defined loop process libraries

[cmsbuild]

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3682/console Started: 2019/11/28 16:42

[cmsbuild]

+1
Tested at: 1be407e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5067dd/3682/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5067dd/3682/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5067dd/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2793840
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2793498
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@fabiocos , this can be merged now (for 11.1.X)

[fabiocos]

@smuzaffar do we have a way from the log-files to verify the increase in size of the distribution?

[smuzaffar]

@fabiocos , no currectly this information is not there but yes this should be a useful information. We will look in to add it to PR results summary page

[smuzaffar]

please test with cms-sw/cms-bot#1231

cms-bot pr tests should now dump some basic statistics about external tools e.g. files count and size

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3922/console Started: 2019/12/11 07:01

[cmsbuild]

+1
Tested at: 8645335
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5067dd/3922/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5067dd/3922/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2800084
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2799741
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@smuzaffar @SiewYan I am re-evaluating the size of the build after this update...

[smuzaffar]

@fabiocos , you can see the size details on the PR summary page under "External Build Stats"

[fabiocos]

@smuzaffar ok, this is the addition you were telling me, very nice!

An addition of 9 GB is not small, still I believe manageable as only the needed libraries will be downloaded and cached by cvmfs...

[fabiocos]

thanks @smuzaffar

@SiewYan at this point if you want to updat ethe 9_3_X backport along these lines it might work, before I make a new build

[SiewYan]

@fabiocos , should i make a new PR ? the PR for 9_3_X is merged though...
@jonaslindert , thanks for the help!!
@smuzaffar , thanks for the check!!

[fabiocos]

@SiewYan yes please, so as we may integrate this extension before making a full new build

[SiewYan]

@fabiocos , I am making the new PR now. Thanks!

[SiewYan]

@fabiocos , I have prepared the PR : #5423
Thanks!