-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use -mlong-double-64 to avoid link error on ppc64le #5398
Conversation
please test for slc7_ppc64_gcc820 |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
The tests are being triggered in jenkins. |
-1 |
please test for slc7_ppc64le_gcc820 |
The tests are being triggered in jenkins. |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
For
ppc64le
, we use-mlong-double-64
( https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_1_X/master/gcc-toolfile.spec#L191 ) to compile cmssw.fftjet
also uses long double but with 128 bits. That causes link error forppc64le
IBs [a]By default fftjey is build in debug mode (
-g -O2
), we explicitly set CXXFLAGS to-O2
to avoid debug build.[a]