Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use -mlong-double-64 to avoid link error on ppc64le #5398

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

smuzaffar
Copy link
Contributor

For ppc64le, we use -mlong-double-64 ( https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_1_X/master/gcc-toolfile.spec#L191 ) to compile cmssw. fftjet also uses long double but with 128 bits. That causes link error for ppc64le IBs [a]

By default fftjey is build in debug mode (-g -O2), we explicitly set CXXFLAGS to -O2 to avoid debug build.

[a]

ld: RecoJets/FFTJetAlgorithms/src/EtaDependentPileup.cc.o uses 64-bit long double, libfftjet.a(libfftjet_la-LinearInterpolator2d.o) uses 128-bit long double
ld: failed to merge target specific data of file libfftjet.a(libfftjet_la-LinearInterpolator2d.o)

@smuzaffar
Copy link
Contributor Author

please test for slc7_ppc64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@smuzaffar
Copy link
Contributor Author

please test for slc7_ppc64le_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3754/console Started: 2019/12/03 15:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3764/console Started: 2019/12/03 17:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72f1c/3764/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the fftjet-long-double-64 branch December 7, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants