Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rootx11 tool file definition #5416

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#28583
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3874/console Started: 2019/12/09 12:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the rootx11-fix branch December 11, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants